improve(error-handling): return Result instead of panic #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCzar
force-pushed
the
improve-error-handling-and-tests
branch
5 times, most recently
from
810994f to
2032417
Compare
Instead of panicking return proper Results with custom error type. This allows for better error messages and also increases testability, allowing for more comprehensive testing of validation errors. Bring in test_case crate, which makes data-table driven tests possible and rewrite tests to take advantage of this. Also fix a bug, where upper bound of the value range wasn't treated as valid speed option.
AlexCzar
force-pushed
the
improve-error-handling-and-tests
branch
from
2032417 to
fef89cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of panicking return proper Results with custom error type.
This allows for better error messages and also increases testability, allowing for more comprehensive testing of validation errors.
Bring in test_case crate, which makes data-table driven tests possible and rewrite tests to take advantage of this.
Also fix a bug, where upper bound of the value range wasn't treated as valid speed option.