AdminのControllerのAuthorizeに渡す値が誤っている問題を修正 #2248

KentaHizume · 2025-01-08T09:52:18Z

この Pull request で実施したこと

Admin の Controller において、 Authorize属性を用いてロールに基づく認可を行う際に、定数クラスRolesで定義したロールの文字列を正しく参照できていない問題を修正しました。
フロントエンド側の下記の変更に備えて、管理者ロールを表す定数の文字列をmaia側に揃えてROLE_ADMINに変更しました。
- ユーザーのロールに応じてボタンの表示を活性・非活性にする maia#1798

問題の詳細

ロールの文字列のべた書きを防ぐために定数クラスから文字列を引き渡すことが最も自然ですが、
属性引数の制約から、（[Authorize(Roles = Roles.Admin]はできません。
ロールの文字列をconstにすることで回避可能ですが、定数値をdll外に公開するpublic constは推奨されません。

達成したいこと

Authorize属性の引数について、文字列のべた書きを避ける
public const な定数の定義を避ける

行ったこと

ロールに基づく認可処理を、ポリシーベースの実装方法に書き換えました。
ポリシーを区別するキーとなる値を internal const で定義することで、定数値をdll外に公開しないようにしました。

この Pull request では実施していないこと

なし

Issues や Discussions 、関連する Web サイトなどへのリンク

const のバージョニング問題
 CS0182
ポリシーベースのロールチェック

github-actions · 2025-01-09T00:30:48Z

Test Result 📝

Test was a success.
Completed in 24832ms with 262 passed, 0 failed and 0 skipped.

Coverage 📐

Summary


Generated on:	01/09/2025 - 00:30:47
Coverage date:	01/09/2025 - 00:30:39 - 01/09/2025 - 00:30:43
Parser:	MultiReport (6x Cobertura)
Assemblies:	8
Classes:	139
Files:	134
Line coverage:	40.7% (1824 of 4475)
Covered lines:	1824
Uncovered lines:	2651
Coverable lines:	4475
Total lines:	10114
Branch coverage:	48% (247 of 514)
Covered branches:	247
Total branches:	514
Method coverage:	Feature is only available for sponsors
Tag:	101_12668121890

Dressca.ApplicationCore - 94.3%

Name	Line	Branch
Dressca.ApplicationCore	94.3%	80.6%
Dressca.ApplicationCore.Accounting.Account	100%	100%
Dressca.ApplicationCore.Accounting.AccountItem	100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions	100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService	100%	70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService	100%	83.3%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit oryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo sitoryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito ryException	100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService	100%	78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager	100%	100%
Dressca.ApplicationCore.Assets.Asset	94.4%	100%
Dressca.ApplicationCore.Assets.AssetNotFoundException	100%
Dressca.ApplicationCore.Assets.AssetTypes	100%	100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore	0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException	100%
Dressca.ApplicationCore.Authorization.Roles	100%
Dressca.ApplicationCore.Baskets.Basket	100%	100%
Dressca.ApplicationCore.Baskets.BasketItem	84.2%	75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException	100%
Dressca.ApplicationCore.Catalog.CatalogBrand	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogCategory	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogDomainService	100%	60%
Dressca.ApplicationCore.Catalog.CatalogItem	75.9%	66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset	92.8%	75%
Dressca.ApplicationCore.Events	100%
Dressca.ApplicationCore.Ordering.Address	100%	100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered	100%	100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.Order	100%	87.5%
Dressca.ApplicationCore.Ordering.OrderFactory	100%
Dressca.ApplicationCore.Ordering.OrderItem	88.2%	25%
Dressca.ApplicationCore.Ordering.OrderItemAsset	85.7%	75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException	100%
Dressca.ApplicationCore.Ordering.ShipTo	100%	75%
Dressca.ApplicationCore.Resources.LogMessages	92.5%	100%
Dressca.ApplicationCore.Resources.Messages	88.8%	100%

Dressca.EfInfrastructure - 16.3%

Name	Line	Branch
Dressca.EfInfrastructure	16.3%	40.9%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati on	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration	100%
Dressca.EfInfrastructure.DresscaDbContext	83.7%	50%
Dressca.EfInfrastructure.EfAssetRepository	0%	0%
Dressca.EfInfrastructure.EfBasketRepository	69.6%	50%
Dressca.EfInfrastructure.EfCatalogBrandRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogCategoryRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogRepository	33.3%	50%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension	81.8%	50%
Dressca.EfInfrastructure.EfOrderRepository	100%	50%
Dressca.EfInfrastructure.Events	0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions	60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot	0%
Dressca.EfInfrastructure.Migrations.InitialCreate	0%
Dressca.EfInfrastructure.Resources.Messages	0%	0%

Dressca.Store.Assets.StaticFiles - 9.4%

Name	Line	Branch
Dressca.Store.Assets.StaticFiles	9.4%	0%
Dressca.Store.Assets.StaticFiles.Events	0%
Dressca.Store.Assets.StaticFiles.Resources.LogMessages	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension	100%

Dressca.SystemCommon - 78.2%

Name	Line	Branch
Dressca.SystemCommon	78.2%	84.6%
Dressca.SystemCommon.BusinessError	100%	83.3%
Dressca.SystemCommon.BusinessErrorCollection	88.8%	100%
Dressca.SystemCommon.BusinessException	93.7%	100%
Dressca.SystemCommon.PagedList`1	0%	0%
Dressca.SystemCommon.Resources.Messages	55.5%	100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions	100%
System.ObjectExtensions	100%	50%
System.StringExtentions	100%	100%

Dressca.Web - 27.9%

Name	Line	Branch
Dressca.Web	27.9%	17.6%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Authorization.DummyAuthenticationHandler	0%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler	0%	0%
Dressca.Web.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Configuration.CookieSettings	0%	0%
Dressca.Web.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Configuration.WebServerOptions	0%
Dressca.Web.Controllers.ActionNameHelper	75%	50%
Dressca.Web.Controllers.ErrorController	8.3%	0%
Dressca.Web.Events	100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider	7.8%	25%
Dressca.Web.Resources.LogMessages	55.5%	100%
Dressca.Web.Resources.Messages	54.1%	100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilterBase	100%	83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase	100%	75%

Dressca.Web.Consumer - 41.5%

Name	Line	Branch
Dressca.Web.Consumer	41.5%	24%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Consumer.Assets.AssetExtensions	87.5%	50%
Dressca.Web.Consumer.Baskets.BuyerIdFilterAttribute	96.5%	58.3%
Dressca.Web.Consumer.Baskets.HttpContextExtensions	100%	100%
Dressca.Web.Consumer.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Consumer.Configuration.CookieSettings	100%	100%
Dressca.Web.Consumer.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Consumer.Configuration.WebServerOptions	100%
Dressca.Web.Consumer.Controllers.ApiModel.FindCatalogItemsQuery	0%
Dressca.Web.Consumer.Controllers.AssetsController	0%	0%
Dressca.Web.Consumer.Controllers.BasketItemsController	34.3%	37.5%
Dressca.Web.Consumer.Controllers.CatalogBrandsController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogCategoriesController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogItemsController	0%	0%
Dressca.Web.Consumer.Controllers.OrdersController	88.2%	50%
Dressca.Web.Consumer.Events	0%
Dressca.Web.Consumer.Mapper.BasketItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.BasketMapper	9.5%	25%
Dressca.Web.Consumer.Mapper.CatalogBrandMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogCategoryMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemSummaryResponseMapper	0%	0%
Dressca.Web.Consumer.Mapper.DtoMapperServicesExtension	100%
Dressca.Web.Consumer.Mapper.OrderMapper	95.1%	50%
Dressca.Web.Consumer.Resources.LogMessages	0%	0%
Dressca.Web.Consumer.Resources.Messages	0%	0%
Program	80.8%	75%

Dressca.Web.Consumer.Dto - 58.4%

Name	Line	Branch
Dressca.Web.Consumer.Dto	58.4%	****
Dressca.Web.Consumer.Dto.Accounting.AccountResponse	100%
Dressca.Web.Consumer.Dto.Baskets.BasketItemResponse	0%
Dressca.Web.Consumer.Dto.Baskets.BasketResponse	0%
Dressca.Web.Consumer.Dto.Baskets.PostBasketItemsRequest	100%
Dressca.Web.Consumer.Dto.Baskets.PutBasketItemsRequest	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogBrandResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogCategoryResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemSummaryResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderItemResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderResponse	100%
Dressca.Web.Consumer.Dto.Ordering.PostOrderRequest	100%

Maris.Logging.Testing - 94.2%

Name	Line	Branch
Maris.Logging.Testing	94.2%	100%
Maris.Logging.Testing.Xunit.TestLoggerManager	100%	100%
Maris.Logging.Testing.Xunit.XunitLogger	76.4%	100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider	100%	100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi ons	100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions	100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions	100%

ポリシーを示す文字列をWeb.Admin内にinternal constで定義するように修正

7684610

KentaHizume linked an issue Jan 8, 2025 that may be closed by this pull request

AdminのControllerのAuthorizeに渡している値がおかしい #2247

Closed

KentaHizume added this to the v1.0.0 milestone Jan 8, 2025

tsuna-can-se approved these changes Jan 9, 2025

View reviewed changes

tsuna-can-se added the target: Dressca サンプルアプリケーションDresscaに関係がある label Jan 9, 2025

tsuna-can-se merged commit 523cd65 into main Jan 9, 2025
8 checks passed

tsuna-can-se deleted the bugs/AdminのControllerのAuthorizeに渡している値が不適切 branch January 9, 2025 00:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AdminのControllerのAuthorizeに渡す値が誤っている問題を修正 #2248

AdminのControllerのAuthorizeに渡す値が誤っている問題を修正 #2248

KentaHizume commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

AdminのControllerのAuthorizeに渡す値が誤っている問題を修正 #2248

AdminのControllerのAuthorizeに渡す値が誤っている問題を修正 #2248

Conversation

KentaHizume commented Jan 8, 2025 • edited Loading

この Pull request で実施したこと

問題の詳細

達成したいこと

行ったこと

この Pull request では実施していないこと

Issues や Discussions 、関連する Web サイトなどへのリンク

github-actions bot commented Jan 9, 2025

Test Result 📝

Coverage 📐

KentaHizume commented Jan 8, 2025 •

edited

Loading