アセットコードから改行文字を取り除いてからログ出力する #2192

KentaHizume · 2024-12-27T01:03:21Z

この Pull request で実施したこと

クライアントから引き渡される文字列assetCodeについて、
改行文字を取り除いてからログに出力するよう修正しました。
そのために、string クラスに改行文字を取り除く拡張メソッドを定義しました。

改行文字が含まれる場合、
攻撃者がログに任意の文字列を埋め込むことができるため、
ログを偽装されたり、ログにスクリプトを埋め込まれたりする危険性があります。

この Pull request では実施していないこと

なし

Issues や Discussions 、関連する Web サイトなどへのリンク

https://www.jpcert.or.jp/java-rules/ids03-j.html

...ca/dressca-backend/src/Dressca.ApplicationCore/ApplicationService/AssetApplicationService.cs

samples/Dressca/dressca-backend/tests/Dressca.UnitTests.SystemCommon/StringExtentionsTest.cs

samples/Dressca/dressca-backend/src/Dressca.SystemCommon/StringExtentions.cs

github-actions · 2024-12-27T07:31:07Z

Test Result 📝

Test was a success.
Completed in 33327ms with 262 passed, 0 failed and 0 skipped.

Coverage 📐

Summary


Generated on:	12/27/2024 - 07:31:06
Coverage date:	12/27/2024 - 07:30:55 - 12/27/2024 - 07:31:02
Parser:	MultiReport (6x Cobertura)
Assemblies:	8
Classes:	139
Files:	134
Line coverage:	40.7% (1824 of 4475)
Covered lines:	1824
Uncovered lines:	2651
Coverable lines:	4475
Total lines:	10114
Branch coverage:	48% (247 of 514)
Covered branches:	247
Total branches:	514
Method coverage:	Feature is only available for sponsors
Tag:	92_12513271842

Dressca.ApplicationCore - 94.3%

Name	Line	Branch
Dressca.ApplicationCore	94.3%	80.6%
Dressca.ApplicationCore.Accounting.Account	100%	100%
Dressca.ApplicationCore.Accounting.AccountItem	100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions	100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService	100%	70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService	100%	83.3%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit oryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo sitoryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito ryException	100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService	100%	78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager	100%	100%
Dressca.ApplicationCore.Assets.Asset	94.4%	100%
Dressca.ApplicationCore.Assets.AssetNotFoundException	100%
Dressca.ApplicationCore.Assets.AssetTypes	100%	100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore	0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException	100%
Dressca.ApplicationCore.Authorization.Roles	100%
Dressca.ApplicationCore.Baskets.Basket	100%	100%
Dressca.ApplicationCore.Baskets.BasketItem	84.2%	75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException	100%
Dressca.ApplicationCore.Catalog.CatalogBrand	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogCategory	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogDomainService	100%	60%
Dressca.ApplicationCore.Catalog.CatalogItem	75.9%	66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset	92.8%	75%
Dressca.ApplicationCore.Events	100%
Dressca.ApplicationCore.Ordering.Address	100%	100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered	100%	100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.Order	100%	87.5%
Dressca.ApplicationCore.Ordering.OrderFactory	100%
Dressca.ApplicationCore.Ordering.OrderItem	88.2%	25%
Dressca.ApplicationCore.Ordering.OrderItemAsset	85.7%	75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException	100%
Dressca.ApplicationCore.Ordering.ShipTo	100%	75%
Dressca.ApplicationCore.Resources.LogMessages	92.5%	100%
Dressca.ApplicationCore.Resources.Messages	88.8%	100%

Dressca.EfInfrastructure - 16.3%

Name	Line	Branch
Dressca.EfInfrastructure	16.3%	40.9%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati on	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration	100%
Dressca.EfInfrastructure.DresscaDbContext	83.7%	50%
Dressca.EfInfrastructure.EfAssetRepository	0%	0%
Dressca.EfInfrastructure.EfBasketRepository	69.6%	50%
Dressca.EfInfrastructure.EfCatalogBrandRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogCategoryRepository	20%	50%
Dressca.EfInfrastructure.EfCatalogRepository	33.3%	50%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension	81.8%	50%
Dressca.EfInfrastructure.EfOrderRepository	100%	50%
Dressca.EfInfrastructure.Events	0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions	60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot	0%
Dressca.EfInfrastructure.Migrations.InitialCreate	0%
Dressca.EfInfrastructure.Resources.Messages	0%	0%

Dressca.Store.Assets.StaticFiles - 9.4%

Name	Line	Branch
Dressca.Store.Assets.StaticFiles	9.4%	0%
Dressca.Store.Assets.StaticFiles.Events	0%
Dressca.Store.Assets.StaticFiles.Resources.LogMessages	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension	100%

Dressca.SystemCommon - 78.2%

Name	Line	Branch
Dressca.SystemCommon	78.2%	84.6%
Dressca.SystemCommon.BusinessError	100%	83.3%
Dressca.SystemCommon.BusinessErrorCollection	88.8%	100%
Dressca.SystemCommon.BusinessException	93.7%	100%
Dressca.SystemCommon.PagedList`1	0%	0%
Dressca.SystemCommon.Resources.Messages	55.5%	100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions	100%
System.ObjectExtensions	100%	50%
System.StringExtentions	100%	100%

Dressca.Web - 27.9%

Name	Line	Branch
Dressca.Web	27.9%	17.6%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Authorization.DummyAuthenticationHandler	0%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler	0%	0%
Dressca.Web.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Configuration.CookieSettings	0%	0%
Dressca.Web.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Configuration.WebServerOptions	0%
Dressca.Web.Controllers.ActionNameHelper	75%	50%
Dressca.Web.Controllers.ErrorController	8.3%	0%
Dressca.Web.Events	100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider	7.8%	25%
Dressca.Web.Resources.LogMessages	55.5%	100%
Dressca.Web.Resources.Messages	54.1%	100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilterBase	100%	83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase	100%	75%

Dressca.Web.Consumer - 41.5%

Name	Line	Branch
Dressca.Web.Consumer	41.5%	24%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Consumer.Assets.AssetExtensions	87.5%	50%
Dressca.Web.Consumer.Baskets.BuyerIdFilterAttribute	96.5%	58.3%
Dressca.Web.Consumer.Baskets.HttpContextExtensions	100%	100%
Dressca.Web.Consumer.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Consumer.Configuration.CookieSettings	100%	100%
Dressca.Web.Consumer.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Consumer.Configuration.WebServerOptions	100%
Dressca.Web.Consumer.Controllers.ApiModel.FindCatalogItemsQuery	0%
Dressca.Web.Consumer.Controllers.AssetsController	0%	0%
Dressca.Web.Consumer.Controllers.BasketItemsController	34.3%	37.5%
Dressca.Web.Consumer.Controllers.CatalogBrandsController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogCategoriesController	0%	0%
Dressca.Web.Consumer.Controllers.CatalogItemsController	0%	0%
Dressca.Web.Consumer.Controllers.OrdersController	88.2%	50%
Dressca.Web.Consumer.Events	0%
Dressca.Web.Consumer.Mapper.BasketItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.BasketMapper	9.5%	25%
Dressca.Web.Consumer.Mapper.CatalogBrandMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogCategoryMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemMapper	0%	0%
Dressca.Web.Consumer.Mapper.CatalogItemSummaryResponseMapper	0%	0%
Dressca.Web.Consumer.Mapper.DtoMapperServicesExtension	100%
Dressca.Web.Consumer.Mapper.OrderMapper	95.1%	50%
Dressca.Web.Consumer.Resources.LogMessages	0%	0%
Dressca.Web.Consumer.Resources.Messages	0%	0%
Program	80.8%	75%

Dressca.Web.Consumer.Dto - 58.4%

Name	Line	Branch
Dressca.Web.Consumer.Dto	58.4%	****
Dressca.Web.Consumer.Dto.Accounting.AccountResponse	100%
Dressca.Web.Consumer.Dto.Baskets.BasketItemResponse	0%
Dressca.Web.Consumer.Dto.Baskets.BasketResponse	0%
Dressca.Web.Consumer.Dto.Baskets.PostBasketItemsRequest	100%
Dressca.Web.Consumer.Dto.Baskets.PutBasketItemsRequest	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogBrandResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogCategoryResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemResponse	0%
Dressca.Web.Consumer.Dto.Catalog.CatalogItemSummaryResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderItemResponse	100%
Dressca.Web.Consumer.Dto.Ordering.OrderResponse	100%
Dressca.Web.Consumer.Dto.Ordering.PostOrderRequest	100%

Maris.Logging.Testing - 94.2%

Name	Line	Branch
Maris.Logging.Testing	94.2%	100%
Maris.Logging.Testing.Xunit.TestLoggerManager	100%	100%
Maris.Logging.Testing.Xunit.XunitLogger	76.4%	100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider	100%	100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi ons	100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions	100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions	100%

github-actions · 2024-12-27T07:31:19Z

Test Result 📝

Test was a success.
Completed in 28357ms with 249 passed, 0 failed and 0 skipped.

Coverage 📐

Summary


Generated on:	12/27/2024 - 07:31:17
Coverage date:	12/27/2024 - 07:31:06 - 12/27/2024 - 07:31:13
Parser:	MultiReport (6x Cobertura)
Assemblies:	8
Classes:	121
Files:	119
Line coverage:	36.8% (1544 of 4190)
Covered lines:	1544
Uncovered lines:	2646
Coverable lines:	4190
Total lines:	9345
Branch coverage:	48.5% (205 of 422)
Covered branches:	205
Total branches:	422
Method coverage:	Feature is only available for sponsors
Tag:	40_12513271840

Dressca.ApplicationCore - 89.9%

Name	Line	Branch
Dressca.ApplicationCore	89.9%	79.5%
Dressca.ApplicationCore.Accounting.Account	100%	100%
Dressca.ApplicationCore.Accounting.AccountItem	100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions	100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService	100%	70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService	100%	83.3%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit oryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo sitoryException	100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito ryException	100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService	100%	75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService	100%	78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager	100%	100%
Dressca.ApplicationCore.Assets.Asset	88.8%	100%
Dressca.ApplicationCore.Assets.AssetNotFoundException	100%
Dressca.ApplicationCore.Assets.AssetTypes	100%	100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore	0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException	100%
Dressca.ApplicationCore.Authorization.Roles	100%
Dressca.ApplicationCore.Baskets.Basket	100%	100%
Dressca.ApplicationCore.Baskets.BasketItem	84.2%	75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException	100%
Dressca.ApplicationCore.Catalog.CatalogBrand	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogCategory	84.6%	100%
Dressca.ApplicationCore.Catalog.CatalogDomainService	100%	60%
Dressca.ApplicationCore.Catalog.CatalogItem	72.1%	66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset	85.7%	75%
Dressca.ApplicationCore.Events	100%
Dressca.ApplicationCore.Ordering.Address	61.1%	100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered	90%	100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException	100%
Dressca.ApplicationCore.Ordering.Order	88%	87.5%
Dressca.ApplicationCore.Ordering.OrderFactory	0%
Dressca.ApplicationCore.Ordering.OrderItem	88.2%	25%
Dressca.ApplicationCore.Ordering.OrderItemAsset	85.7%	75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException	100%
Dressca.ApplicationCore.Ordering.ShipTo	58.3%	50%
Dressca.ApplicationCore.Resources.LogMessages	92.5%	100%
Dressca.ApplicationCore.Resources.Messages	88.8%	100%

Dressca.EfInfrastructure - 13.9%

Name	Line	Branch
Dressca.EfInfrastructure	13.9%	9%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration	100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati on	100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio n	100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration	100%
Dressca.EfInfrastructure.DresscaDbContext	83.7%	50%
Dressca.EfInfrastructure.EfAssetRepository	0%	0%
Dressca.EfInfrastructure.EfBasketRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogBrandRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogCategoryRepository	0%	0%
Dressca.EfInfrastructure.EfCatalogRepository	0%	0%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension	81.8%	50%
Dressca.EfInfrastructure.EfOrderRepository	0%	0%
Dressca.EfInfrastructure.Events	0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions	60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot	0%
Dressca.EfInfrastructure.Migrations.InitialCreate	0%
Dressca.EfInfrastructure.Resources.Messages	0%	0%

Dressca.Store.Assets.StaticFiles - 9.4%

Name	Line	Branch
Dressca.Store.Assets.StaticFiles	9.4%	0%
Dressca.Store.Assets.StaticFiles.Events	0%
Dressca.Store.Assets.StaticFiles.Resources.LogMessages	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore	0%	0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension	100%

Dressca.SystemCommon - 77.4%

Name	Line	Branch
Dressca.SystemCommon	77.4%	84.6%
Dressca.SystemCommon.BusinessError	100%	83.3%
Dressca.SystemCommon.BusinessErrorCollection	88.8%	100%
Dressca.SystemCommon.BusinessException	93.7%	100%
Dressca.SystemCommon.PagedList`1	0%	0%
Dressca.SystemCommon.Resources.Messages	55.5%	100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions	100%
System.ObjectExtensions	80%	50%
System.StringExtentions	100%	100%

Dressca.Web - 33%

Name	Line	Branch
Dressca.Web	33%	16.6%
__OptionValidationGeneratedAttributes	0%	0%
__OptionValidationStaticInstances	0%
Dressca.Web.Authorization.DummyAuthenticationHandler	100%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler	0%	0%
Dressca.Web.Configuration.CookieSettingsValidator	0%	0%
Dressca.Web.Configuration.CookieSettings	25%	0%
Dressca.Web.Configuration.ValidateWebServerOptions	0%	0%
Dressca.Web.Configuration.WebServerOptions	100%
Dressca.Web.Controllers.ActionNameHelper	0%	0%
Dressca.Web.Controllers.ErrorController	8.3%	0%
Dressca.Web.Events	100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider	7.8%	25%
Dressca.Web.Resources.LogMessages	55.5%	100%
Dressca.Web.Resources.Messages	54.1%	100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilter	100%	50%
Dressca.Web.Runtime.BusinessExceptionFilterBase	100%	83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter	100%	50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase	100%	75%

Dressca.Web.Admin - 24.8%

Name	Line	Branch
Dressca.Web.Admin	24.8%	9%
Dressca.Web.Admin.Assets.AssetExtensions	0%	0%
Dressca.Web.Admin.Authorization.UserStore	0%	0%
Dressca.Web.Admin.Controllers.ApiModel.FindCatalogItemsQuery	0%
Dressca.Web.Admin.Controllers.AssetsController	0%	0%
Dressca.Web.Admin.Controllers.CatalogBrandsController	0%	0%
Dressca.Web.Admin.Controllers.CatalogCategoriesController	0%	0%
Dressca.Web.Admin.Controllers.CatalogItemsController	0%	0%
Dressca.Web.Admin.Controllers.UsersController	0%	0%
Dressca.Web.Admin.Events	0%
Dressca.Web.Admin.Mapper.CatalogBrandMapper	0%	0%
Dressca.Web.Admin.Mapper.CatalogCategoryMapper	0%	0%
Dressca.Web.Admin.Mapper.CatalogItemMapper	0%	0%
Dressca.Web.Admin.Mapper.DtoMapperServicesExtension	100%
Dressca.Web.Admin.Resources.LogMessages	0%	0%
Dressca.Web.Admin.Resources.Messages	0%	0%
Program	79.2%	60%

Dressca.Web.Admin.Dto - 0%

Name	Line	Branch
Dressca.Web.Admin.Dto	0%	****
Dressca.Web.Admin.Dto.CatalogBrands.GetCatalogBrandsResponse	0%
Dressca.Web.Admin.Dto.CatalogCategories.GetCatalogCategoriesResponse	0%
Dressca.Web.Admin.Dto.CatalogItems.GetCatalogItemResponse	0%
Dressca.Web.Admin.Dto.CatalogItems.PostCatalogItemRequest	0%
Dressca.Web.Admin.Dto.CatalogItems.PutCatalogItemRequest	0%
Dressca.Web.Admin.Dto.Users.GetLoginUserResponse	0%

Maris.Logging.Testing - 94.2%

Name	Line	Branch
Maris.Logging.Testing	94.2%	100%
Maris.Logging.Testing.Xunit.TestLoggerManager	100%	100%
Maris.Logging.Testing.Xunit.XunitLogger	76.4%	100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider	100%	100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi ons	100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions	100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions	100%

アセットコードから改行文字を取り除いてからログ出力する

435503f

KentaHizume added 不具合現在リリース中のバージョンに不具合・バグがある target: Dressca サンプルアプリケーションDresscaに関係がある labels Dec 27, 2024

KentaHizume added this to the v1.0.0 milestone Dec 27, 2024

KentaHizume self-assigned this Dec 27, 2024

This was linked to issues Dec 27, 2024

Fix code scanning alert - Log entries created from user input #2188

Closed

Fix code scanning alert - Log entries created from user input #2189

Closed

KentaHizume requested a review from tsuna-can-se December 27, 2024 01:04

tsuna-can-se requested changes Dec 27, 2024

View reviewed changes

...ca/dressca-backend/src/Dressca.ApplicationCore/ApplicationService/AssetApplicationService.cs Outdated Show resolved Hide resolved

改行文字を取り除くstringの拡張メソッドを定義

e391e3b

tsuna-can-se requested changes Dec 27, 2024

View reviewed changes

samples/Dressca/dressca-backend/tests/Dressca.UnitTests.SystemCommon/StringExtentionsTest.cs Outdated Show resolved Hide resolved

tsuna-can-se requested changes Dec 27, 2024

View reviewed changes

samples/Dressca/dressca-backend/src/Dressca.SystemCommon/StringExtentions.cs Outdated Show resolved Hide resolved

KentaHizume added 3 commits December 27, 2024 14:52

テストスイートの単位を修正

7ac071a

null の入力に対して null を返却するように修正

0dabc84

メソッド名を NewlineCharacters に変更

7c1b4e3

tsuna-can-se approved these changes Dec 27, 2024

View reviewed changes

tsuna-can-se merged commit d25d012 into main Dec 27, 2024
8 checks passed

tsuna-can-se deleted the feature/クライアントから渡されたアセットコードをサニタイズする branch December 27, 2024 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

アセットコードから改行文字を取り除いてからログ出力する #2192

アセットコードから改行文字を取り除いてからログ出力する #2192

KentaHizume commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

アセットコードから改行文字を取り除いてからログ出力する #2192

アセットコードから改行文字を取り除いてからログ出力する #2192

Conversation

KentaHizume commented Dec 27, 2024 • edited Loading

この Pull request で実施したこと

この Pull request では実施していないこと

Issues や Discussions 、関連する Web サイトなどへのリンク

github-actions bot commented Dec 27, 2024

Test Result 📝

Coverage 📐

github-actions bot commented Dec 27, 2024

Test Result 📝

Coverage 📐

KentaHizume commented Dec 27, 2024 •

edited

Loading