Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

コード分析の警告に対処する #1395

Merged
merged 13 commits into from
Jun 28, 2024
Merged

コード分析の警告に対処する #1395

merged 13 commits into from
Jun 28, 2024

Conversation

tsuna-can-se
Copy link
Contributor

コード分析の警告及び情報に可能な限り対応しました。
C#12 で利用可能になった構文を中心に変更しています。

@tsuna-can-se
インスタンスメンバーを使用しないメソッドを静的メソッドに変更
125f40a
@tsuna-can-se
テストクラス内での配列初期化方法を簡略化
4d6190e
@tsuna-can-se
簡略化された using 宣言を利用するように修正
803efb2
@tsuna-can-se
不要なusingディレクティブを削除
c9ba884
@tsuna-can-se
リストの初期化にコレクション初期化子を使用するよう修正
ee994c2
@tsuna-can-se
インスタンス生成にオブジェクト初期化子を使用するように修正
c0122de
@tsuna-can-se
コレクション初期化子を使用するように修正
7dcd2eb
@tsuna-can-se
AnyのかわりにCountやLengthと比較するよう修正
aad2c43
@tsuna-can-se
メソッドのカスタム属性の引数にnameofを利用して引数名を指定するよう修正
f2c7a95
@tsuna-can-se
不要なusingを削除
e3dea24
@tsuna-can-se
読み取り専用フィールドに変更
e3dc200
@tsuna-can-se
コレクション初期化子を使うように修正
8b619ed
@tsuna-can-se
AnyのかわりにCountを使って比較するように修正
1a92629
@tsuna-can-se tsuna-can-se added target: Dressca サンプルアプリケーションDresscaに関係がある target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある target: Azure AD B2C Auth Azure AD B2C認証の要件別サンプルに関係がある 要件別サンプル labels Jun 28, 2024
@tsuna-can-se tsuna-can-se added this to the v0.9.2 milestone Jun 28, 2024
@tsuna-can-se tsuna-can-se requested a review from KentaHizume June 28, 2024 06:57
@tsuna-can-se tsuna-can-se self-assigned this Jun 28, 2024
@github-actions GitHub Actions
Copy link

Test Result 📝

Test was a success.
Completed in 24327ms with 209 passed, 0 failed and 0 skipped.

Coverage 📐

Summary
Generated on: 06/28/2024 - 06:59:31
Coverage date: 06/28/2024 - 06:59:23 - 06/28/2024 - 06:59:27
Parser: MultiReport (3x Cobertura)
Assemblies: 7
Classes: 120
Files: 119
Line coverage: 32.5% (1550 of 4765)
Covered lines: 1550
Uncovered lines: 3215
Coverable lines: 4765
Total lines: 9594
Branch coverage: 50.7% (202 of 398)
Covered branches: 202
Total branches: 398
Method coverage: Feature is only available for sponsors
Tag: 615_9708752561
Dressca.ApplicationCore - 91%
Name Line Branch
Dressca.ApplicationCore 91% 76.3%
Dressca.ApplicationCore.Accounting.Account 100% 100%
Dressca.ApplicationCore.Accounting.AccountItem 100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions 100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService 100% 70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService 100% 50%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService 100% 75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService 100% 78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager 100% 100%
Dressca.ApplicationCore.Assets.Asset 94.4% 100%
Dressca.ApplicationCore.Assets.AssetNotFoundException 100%
Dressca.ApplicationCore.Assets.AssetTypes 100% 100%
Dressca.ApplicationCore.Baskets.Basket 100% 100%
Dressca.ApplicationCore.Baskets.BasketItem 84.2% 75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException 100%
Dressca.ApplicationCore.Catalog.CatalogBrand 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogCategory 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogDomainService 100% 66.6%
Dressca.ApplicationCore.Catalog.CatalogItem 54% 37.5%
Dressca.ApplicationCore.Catalog.CatalogItemAsset 92.8% 75%
Dressca.ApplicationCore.Catalog.CatalogItemNotExistingInRepositoryException 100%
Dressca.ApplicationCore.Events 100%
Dressca.ApplicationCore.Ordering.Address 100% 100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered 100% 100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.Order 100% 87.5%
Dressca.ApplicationCore.Ordering.OrderFactory 100%
Dressca.ApplicationCore.Ordering.OrderItem 88.2% 25%
Dressca.ApplicationCore.Ordering.OrderItemAsset 85.7% 75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException 100%
Dressca.ApplicationCore.Ordering.ShipTo 100% 75%
Dressca.ApplicationCore.Resources.LogMessages 88.8% 100%
Dressca.ApplicationCore.Resources.Messages 71.6% 100%
Dressca.EfInfrastructure - 12%
Name Line Branch
Dressca.EfInfrastructure 12% 31.8%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration 100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration 100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio
n		 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati
on		 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio
n		 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration 100%
Dressca.EfInfrastructure.DresscaDbContext 83.7% 50%
Dressca.EfInfrastructure.EfAssetRepository 0% 0%
Dressca.EfInfrastructure.EfBasketRepository 69.6% 50%
Dressca.EfInfrastructure.EfCatalogBrandRepository 0% 0%
Dressca.EfInfrastructure.EfCatalogCategoryRepository 0% 0%
Dressca.EfInfrastructure.EfCatalogRepository 92.3% 50%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension 81.8% 50%
Dressca.EfInfrastructure.EfOrderRepository 100% 50%
Dressca.EfInfrastructure.Events 0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions 60%
Dressca.EfInfrastructure.Migrations.AddNowPrintingAsset 0%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot 0%
Dressca.EfInfrastructure.Migrations.InitialCreate 0%
Dressca.EfInfrastructure.Resources.Messages 0% 0%
Dressca.Store.Assets.StaticFiles - 9.4%
Name Line Branch
Dressca.Store.Assets.StaticFiles 9.4% 0%
Dressca.Store.Assets.StaticFiles.Events 0%
Dressca.Store.Assets.StaticFiles.Resources.LogMessages 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension 100%
Dressca.SystemCommon - 88.3%
Name Line Branch
Dressca.SystemCommon 88.3% 90.9%
Dressca.SystemCommon.BusinessError 100% 83.3%
Dressca.SystemCommon.BusinessErrorCollection 88.8% 100%
Dressca.SystemCommon.BusinessException 93.7% 100%
Dressca.SystemCommon.ObjectExtensions 100% 50%
Dressca.SystemCommon.Resources.Messages 55.5% 100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions 100%
Dressca.Web - 42.6%
Name Line Branch
Dressca.Web 42.6% 27.2%
__OptionValidationGeneratedAttributes 0% 0%
__OptionValidationStaticInstances 0%
Dressca.Web.Assets.AssetExtensions 87.5% 50%
Dressca.Web.Baskets.BuyerIdFilterAttribute 96.5% 58.3%
Dressca.Web.Baskets.HttpContextExtensions 100% 100%
Dressca.Web.Configuration.CookieSettingsValidator 0% 0%
Dressca.Web.Configuration.CookieSettings 100% 100%
Dressca.Web.Configuration.ValidateWebServerOptions 0% 0%
Dressca.Web.Configuration.WebServerOptions 100%
Dressca.Web.Controllers.ActionNameHelper 75% 50%
Dressca.Web.Controllers.ApiModel.FindCatalogItemsQuery 0%
Dressca.Web.Controllers.AssetsController 0% 0%
Dressca.Web.Controllers.BasketItemsController 34.3% 37.5%
Dressca.Web.Controllers.CatalogBrandsController 0% 0%
Dressca.Web.Controllers.CatalogCategoriesController 0% 0%
Dressca.Web.Controllers.CatalogItemsController 0% 0%
Dressca.Web.Controllers.ErrorController 0% 0%
Dressca.Web.Controllers.OrdersController 88.2% 50%
Dressca.Web.Events 100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider 7.8% 25%
Dressca.Web.Mapper.BasketItemMapper 0% 0%
Dressca.Web.Mapper.BasketMapper 9.5% 25%
Dressca.Web.Mapper.CatalogBrandMapper 0% 0%
Dressca.Web.Mapper.CatalogCategoryMapper 0% 0%
Dressca.Web.Mapper.CatalogItemMapper 0% 0%
Dressca.Web.Mapper.CatalogItemSummaryResponseMapper 0% 0%
Dressca.Web.Mapper.DtoMapperServicesExtension 100%
Dressca.Web.Mapper.OrderMapper 95.1% 50%
Dressca.Web.Resources.LogMessages 0% 0%
Dressca.Web.Resources.Messages 41.6% 100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilterBase 100% 83.3%
Program 80.8% 75%
Dressca.Web.Dto - 45.5%
Name Line Branch
Dressca.Web.Dto 45.5% 0%
Dressca.Web.Dto.Accounting.AccountResponse 100%
Dressca.Web.Dto.Baskets.BasketItemResponse 0%
Dressca.Web.Dto.Baskets.BasketResponse 0%
Dressca.Web.Dto.Baskets.PostBasketItemsRequest 100%
Dressca.Web.Dto.Baskets.PutBasketItemsRequest 0%
Dressca.Web.Dto.Catalog.CatalogBrandResponse 0%
Dressca.Web.Dto.Catalog.CatalogCategoryResponse 0%
Dressca.Web.Dto.Catalog.CatalogItemResponse 0%
Dressca.Web.Dto.Catalog.CatalogItemSummaryResponse 100%
Dressca.Web.Dto.Ordering.OrderItemResponse 100%
Dressca.Web.Dto.Ordering.OrderResponse 100%
Dressca.Web.Dto.Ordering.PostOrderRequest 100%
Dressca.Web.Dto.PagedList`1 0% 0%
Maris.Logging.Testing - 94.2%
Name Line Branch
Maris.Logging.Testing 94.2% 100%
Maris.Logging.Testing.Xunit.TestLoggerManager 100% 100%
Maris.Logging.Testing.Xunit.XunitLogger 76.4% 100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider 100% 100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi
ons		 100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions 100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions 100%

KentaHizume
KentaHizume approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@KentaHizume KentaHizume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

・各サンプルアプリが動作すること
・Code Analysysを実行して警告が出ないこと
・Code AnalysysのInfoレベルのメッセージについて、
今回修正したものと同じカテゴリで修正したほうがよさそうなものが見当たらないこと
を確認いたしました。

@KentaHizume KentaHizume merged commit febec08 into main Jun 28, 2024
4 checks passed
@KentaHizume KentaHizume deleted the feature/コード分析の警告に対処する branch June 28, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentaHizume KentaHizume KentaHizume approved these changes

Assignees

@tsuna-can-se tsuna-can-se

Labels
target: Azure AD B2C Auth Azure AD B2C認証の要件別サンプルに関係がある target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある target: Dressca サンプルアプリケーションDresscaに関係がある
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tsuna-can-se @KentaHizume