テストクラスのcatch内におけるfail()メソッドの削除

AlesInfiny · Nov 6, 2023 · daa5561 · daa5561
1 parent 3e12b33
commit daa5561
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 15 deletions.
diff --git a/...on-core/src/test/java/com/dressca/applicationcore/assets/AssetApplicationServiceTest.java b/...on-core/src/test/java/com/dressca/applicationcore/assets/AssetApplicationServiceTest.java
@@ -50,7 +50,6 @@ public class AssetApplicationServiceTest {
       verify(this.store, times(1)).getResource(asset);
     } catch (AssetNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 

diff --git a/...-core/src/test/java/com/dressca/applicationcore/baskets/BasketApplicationServiceTest.java b/...-core/src/test/java/com/dressca/applicationcore/baskets/BasketApplicationServiceTest.java
@@ -51,7 +51,6 @@ public class BasketApplicationServiceTest {
       verify(this.repository, times(1)).update(basket);
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 
@@ -79,7 +78,6 @@ public class BasketApplicationServiceTest {
       assertThat(argBasket.getItems().size()).isEqualTo(0);
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 
@@ -123,7 +121,6 @@ public class BasketApplicationServiceTest {
       verify(this.repository, times(1)).remove(basket);;
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 
@@ -165,7 +162,6 @@ public class BasketApplicationServiceTest {
       verify(this.repository, times(1)).update(basket);
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 
@@ -191,7 +187,6 @@ public class BasketApplicationServiceTest {
       assertThat(argBasket.getItems().size()).isEqualTo(0);
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 
@@ -220,7 +215,6 @@ public class BasketApplicationServiceTest {
       assertThat(argBasket.getItems().get(0).getQuantity()).isEqualTo(newQuantity);
     } catch (BasketNotFoundException e) {
       e.printStackTrace();
-      fail(e);
     }
   }
 

diff --git a/...ion-core/src/test/java/com/dressca/applicationcore/order/OrderApplicationServiceTest.java b/...ion-core/src/test/java/com/dressca/applicationcore/order/OrderApplicationServiceTest.java
@@ -55,7 +55,7 @@ public class OrderApplicationServiceTest {
     try {
       service.createOrder(basketId, shipToAddress);
     } catch (Exception e) {
-      fail("例外は発生しないはず", e);
+      e.printStackTrace();
     }
 
     // Assert
@@ -107,7 +107,7 @@ public class OrderApplicationServiceTest {
     try {
       actual = service.getOrder(orderId, buyerId);
     } catch (Exception e) {
-      fail("例外は発生しないはず", e);
+      e.printStackTrace();
     }
 
     // Assert

diff --git a/...sr/dressca-backend/web/src/test/java/com/dressca/web/controller/AssetsControllerTest.java b/...sr/dressca-backend/web/src/test/java/com/dressca/web/controller/AssetsControllerTest.java
@@ -1,6 +1,5 @@
 package com.dressca.web.controller;
 
-import static org.junit.jupiter.api.Assertions.fail;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
@@ -37,7 +36,6 @@ void testGet_01() {
         .andExpect(content().contentType(MediaType.IMAGE_PNG_VALUE));
     } catch (Exception e) {
       e.printStackTrace();
-      fail();
     }
   }
 
@@ -52,7 +50,6 @@ void testGet_02() {
         .andExpect(status().isNotFound());
     } catch (Exception e) {
       e.printStackTrace();
-      fail();
     }
   }
 }
diff --git a/...web-csr/dressca-backend/web/src/test/java/com/dressca/web/controller/HealthCheckTest.java b/...web-csr/dressca-backend/web/src/test/java/com/dressca/web/controller/HealthCheckTest.java
@@ -1,6 +1,5 @@
 package com.dressca.web.controller;
 
-import static org.junit.jupiter.api.Assertions.fail;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
@@ -32,7 +31,6 @@ void testGet_serverCheck() {
           .andExpect(content().json("{'status':'UP'}"));
       } catch (Exception e) {
         e.printStackTrace();
-        fail();
       }
     }
 
@@ -45,7 +43,6 @@ void testGet_databaseCheck() {
           .andExpect(content().json("{'status':'UP'}"));
       } catch (Exception e) {
         e.printStackTrace();
-        fail();
       }
     }
 }