Optimize sia download #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests Added new fucntion to readdbc module
updated SIA documentation
|
This PR also solves #27. Thanks to @heber-augusto for helping to detail this problem, and @alfonso777 for issue 27! |
|
about the CI error, I guess you will need to add so conda/mamba can handle the dependency constraint for numba |
heber-augusto
suggested changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #64 by not loading large SIA files into memory.
Instead, it save the
dbfin the PySUS' cache directory and offers the user a chance to load the dataset in chunks.This PR also adds some auxiliary functions to the readdbc module, mainly to stream converting
dbcfiles todbf, anddbfintocsv.gzfiles.