Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mudei a versão máxima do Python para <3.13 #206

Merged
merged 2 commits into from
Oct 19, 2024
Merged

mudei a versão máxima do Python para <3.13 #206

merged 2 commits into from
Oct 19, 2024

Conversation

fccoelho
Copy link
Collaborator

@fccoelho fccoelho commented Oct 2, 2024

deprequei o módulo geodata por causa da dependência com o pacote geobr que depende de uma versão muito antiga do shapely que não instala.

Tudo parece estar funcionando, com exceção do módulo de vacinação de COVID que eu acho que deveria ser deprecado em favor dos dados de vacinação do PNI que existem no FTP server.

@fccoelho
mudei a versão máxima do Python para <3.13
dcfb6aa 
deprequei od módulo geodata por causa da dependência com o pacote geobr que depende de uma versão muito antiga do shaeply que não instala.
@fccoelho fccoelho requested a review from luabida October 2, 2024 18:46
@fccoelho fccoelho linked an issue Oct 2, 2024 that may be closed by this pull request
bump max python version to 3.12x #196
Closed
@felipeadeildo
Copy link
Contributor

Olá!

Consegue definir uma versão mínima também?
Colocar um limite superior estrito à < 3.13 me deixa aberto a tentar com outras versões o que dificulta a utilização num ambiente controlado.

luabida
luabida reviewed Oct 3, 2024
View reviewed changes
poetry.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does poetry.lock have to be removed from repo? poetry.lock is important to avoid dependency conflicts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it again. I deleted it to facilitate rebuilding the venv from scratch with a newer version of Python

@fccoelho
Copy link
Collaborator Author

fccoelho commented Oct 3, 2024

Olá!

Consegue definir uma versão mínima também? Colocar um limite superior estrito à < 3.13 me deixa aberto a tentar com outras versões o que dificulta a utilização num ambiente controlado.

Acho razoável exigir pelo menos 3.11. Atualmente está como 3.10

@fccoelho fccoelho marked this pull request as ready for review October 9, 2024 14:00
@fccoelho fccoelho requested a review from luabida October 9, 2024 14:00
luabida
luabida approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@luabida luabida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fccoelho fccoelho merged commit 36910bc into main Oct 19, 2024
2 of 6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luabida luabida luabida approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump max python version to 3.12x
3 participants
@fccoelho @felipeadeildo @luabida