Load Base Controller Extension when autoloading #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Nov 22, 2024
mamhoff
force-pushed
the
autoloadable-extension
branch
from
30e8f2e to
4bafa9b
Compare
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
4bafa9b to
844102b
Compare
Let's use Zeitwerk to lazy load our extension.
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
844102b to
9f3cf62
Compare
tvdeyen
requested changes
Jan 24, 2025
| @@ -19,6 +19,7 @@ group :test do | |||
| gem "pg", "~> 1.0" if ENV["DB"] == "postgresql" | |||
| end | |||
|
|
|||
| gem "solidus_support", github: "mamhoff/solidus_support", branch: "re-enable-flickwerk" | |||
There was a problem hiding this comment.
This is not necessary, because we do not load Solidus in this gem
Suggested change
| gem "solidus_support", github: "mamhoff/solidus_support", branch: "re-enable-flickwerk" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use Zeitwerk to lazy load our extension.