Hydrofab2ngen tools #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JordanLaserGit That would save everyone quite a bit of time and could be a step towards more efficient data access... |
|
watching |
jameshalgren
commented
May 3, 2023
prep_hydrofab_forcings_ngen.py
Outdated
|
|
||
| def aorc_as_rate(dataFrame): | ||
| """ | ||
| Convert kg/m^2 -> m/s |
There was a problem hiding this comment.
Maybe these two can live in some AORC tool repo. Would that be something to put in hydrotools?
jameshalgren
commented
May 20, 2023
Comment on lines
22
to
23
| import matplotlib.pyplot as plt | ||
| from mpl_toolkits.basemap import Basemap |
|
Almost there -- need to resolve subset import issue. |
…' into hydrofab2ngen_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces original intent of #26
Remaining checkmarks still to be examined, possibly through #26, refreshed.
Working on this with respect to #24.
Work remaining might include the following:
--enable-parallelflag or here - possibly change to access pattern)How to test:
Download a set of test data files to use with
python prep_hydrofab_forcings_ngen.py user_input_ngen.json:with the default configuration downloading 18 hours of Short Range forecast and the 03W VPU, it can generate the 30000 feature time series in just a minute or so after generating the .json file with the weights. Unfortunately, generating that file takes almost 20 minutes and is an opportunity for optimization.