Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

separate network resource and ec2 instance creation using data block #36

Merged
merged 3 commits into from
Apr 17, 2023
Merged

separate network resource and ec2 instance creation using data block #36

merged 3 commits into from
Apr 17, 2023

Conversation

benlee0423
Copy link
Collaborator

@benlee0423 benlee0423 commented Apr 12, 2023

This change is related to #9.

  1. Separate TF script into two separate directory, network related resource creation and ec2 instance creation.
  2. Clean up and refactor existing TF code.
  3. As a user, run TF code in user directory.

TODO: find a way to mount S3 bucket into the docker container.

Copy link
Contributor

@arpita0911patel arpita0911patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the PR and tested on my local machine, it worked great.

@benlee0423
Copy link
Collaborator Author

@ZacharyWills Please review/approve it when you have time.

To run the Terraform configuration, follow these steps:
** Note that terraform configuration in network directory will setup initial VPC and subnets, only runs once by administrator.
To run the Terraform configuration as a user, follow these steps in user directory under terraform:
As a pre-requisite step, create a key-pair in AWS EC2 console, and place the key in user directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to list the directory here as the users might not have a lot of experience with AWS.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Copy link
Contributor

@ZacharyWills ZacharyWills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, add the location for the AWS keys and we can merge.

@jameshalgren jameshalgren merged commit 6173d16 into AlabamaWaterInstitute:main Apr 17, 2023
jameshalgren added a commit that referenced this pull request Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants