-
Notifications
You must be signed in to change notification settings - Fork 24
separate network resource and ec2 instance creation using data block #36
separate network resource and ec2 instance creation using data block #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out the PR and tested on my local machine, it worked great.
@ZacharyWills Please review/approve it when you have time. |
To run the Terraform configuration, follow these steps: | ||
** Note that terraform configuration in network directory will setup initial VPC and subnets, only runs once by administrator. | ||
To run the Terraform configuration as a user, follow these steps in user directory under terraform: | ||
As a pre-requisite step, create a key-pair in AWS EC2 console, and place the key in user directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to list the directory here as the users might not have a lot of experience with AWS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, add the location for the AWS keys and we can merge.
This change is related to #9.
TODO: find a way to mount S3 bucket into the docker container.