Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fucntion is working now #1455 #1774

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Replace fucntion is working now #1455 #1774

wants to merge 3 commits into from

Conversation

NmN03jain
Copy link

Thank you for the time you are putting into AlaSQL!

mathiasrw
mathiasrw requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@mathiasrw mathiasrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test file that verifies the bahavour so we dont accidentally break it at some point.

Copy the test/test000.js to test/test1455.js and adapt the logic

@NmN03jain
Copy link
Author

@mathiasrw requested chages are made ,can you pls verify .

@NmN03jain
Copy link
Author

@mathiasrw what changes i need to performe ?

@NmN03jain NmN03jain requested a review from mathiasrw August 15, 2023 16:04
@mathiasrw
Copy link
Member

image

Please insert a .toString() at the end of the value and make sure we dont throw an error.

@mathiasrw mathiasrw mentioned this pull request Aug 17, 2023
Open
@NmN03jain
Copy link
Author

@mathiasrw any more changes required ?

@mathiasrw
Copy link
Member

Yes. Please see the pending review changes

image image image

@mathiasrw
Copy link
Member

Please make sure that npx yarn test is working locally before pushing.

@mathiasrw
Copy link
Member

How can I help get the last little bits aligned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasrw mathiasrw Awaiting requested review from mathiasrw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NmN03jain @mathiasrw