Include test cases for handling zero-size files in rohmu #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xlianhu
force-pushed
the
0xlianhu-add-rohmu-acceptance-tests
branch
from
cbbc02d to
ec949c4
Compare
0xlianhu
force-pushed
the
0xlianhu-add-rohmu-acceptance-tests
branch
3 times, most recently
from
a67121c to
e3a31e2
Compare
0xlianhu
force-pushed
the
0xlianhu-add-rohmu-acceptance-tests
branch
from
e3a31e2 to
e567df9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 66.76% 70.93% +4.16%
==========================================
Files 35 35
Lines 3909 3909
==========================================
+ Hits 2610 2773 +163
+ Misses 1299 1136 -163 ☔ View full report in Codecov by Sentry. |
packi
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases to test Rohmu handle zero size files:
Generate an empty file -> compress(lzma/zstd/snappy) and encrypt -> upload (local file system) -> download, decrypt+decompress -> Verify if download files are expected files