-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade exporter to be compatible with OpenSearch 2.18.0 #316
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Victor Nilsson <[email protected]>
Guys! realy need your plugin to be updated to 2.18 version - without it no monitoring on 2.18 clusters built by official helm charts. Your work is very important! |
Ping @lukas-vlcek |
@vinylen I am on it, I hope it can be done by the end of this week. Monday at the latest. |
We are really looking forward to it :) |
Ping @lukas-vlcek |
Should this project be forked? Is there some reason why you've been drawn away from maintenance @lukas-vlcek ? Not to be pushy at all, I'm curious about what the community should expect. |
Yes or what if we add more people as maintainers? More of us that can assist with the release of the exporter so it doesn't solely have to be Lukas. Might be tricky since it's under Aiven? |
Is there an ETA on when this may be completed or an alternative fork for 2.18.0.0 support? |
If it’s just a version bump, do we have to wait for the plugin 2.18.0.0 release or will the current released version also work with OS 2.18.0? 🤔 |
no, it doesn't because - like all plugins using the OpenSearch gradle plugin - it's not yet using a semver range to describe its compatibility with OpenSearch (this requires opensearch-project/OpenSearch#13187 to be implemented). however, you can always clone the repo locally, adapt it to a new version and create your own build with that. it just won't be an official build. |
@lukas-vlcek Can someone else from Aiven step in and handle this release? Pinging @bogdanp05 here as well (if that works) since they seem to be the person responsible for Aiven-Open. I've also emailed [email protected] about this PR last week but i've yet to receive any response. |
Hello, until this PR will be merged, you can use this: Please don't use it on production, I just built it and uploaded, works in my case, but can't guarantee anything. |
Also works in my case |
…arch 2.18 Upstream release of this plugging is lagging. Bump the compat version of it by hand. Also see: - Aiven-Open/prometheus-exporter-plugin-for-opensearch#317 - Aiven-Open/prometheus-exporter-plugin-for-opensearch#316
…arch 2.18 (#37298) Upstream release of this plugging is lagging. Bump the compat version of it by hand. Also see: - Aiven-Open/prometheus-exporter-plugin-for-opensearch#317 - Aiven-Open/prometheus-exporter-plugin-for-opensearch#316 With this change, opensearch 2.18 with this plugin works again; and deploys in a helm chart.
Description
Upgrades exporter to be compatible with OpenSearch 2.18.0
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.