Simplify code: Fix typos, refactor logic, and remove unused parameters.

src/main/java/io/aiven/kafka/connect/opensearch/DocumentIDStrategy.java

@@ -42,7 +42,7 @@ record -> String.format("%s+%s+%s", record.topic(), record.kafkaPartition(), rec
 
     private final Function<SinkRecord, String> docIdGenerator;
 
-    private DocumentIDStrategy(final String name, final String description,
+    DocumentIDStrategy(final String name, final String description,
             final Function<SinkRecord, String> docIdGenerator) {
         this.name = name.toLowerCase(Locale.ROOT);
         this.description = description;
@@ -74,7 +74,7 @@ public static String describe() {
     }
 
     public static final ConfigDef.Validator VALIDATOR = new ConfigDef.Validator() {
-        private final String[] names = Arrays.stream(values()).map(v -> v.toString()).toArray(String[]::new);
+        private final String[] names = Arrays.stream(values()).map(Object::toString).toArray(String[]::new);
         private final ConfigDef.ValidString validator = ConfigDef.ValidString.in(names);
 
         @Override

src/main/java/io/aiven/kafka/connect/opensearch/OpensearchClient.java

@@ -245,10 +245,10 @@ public HttpAsyncClientBuilder customizeHttpClient(final HttpAsyncClientBuilder h
                     .build();
 
             final Collection<OpensearchClientConfigurator> configurators = ClientsConfiguratorProvider
-                    .forOpensearch(config);
+                    .forOpensearch();
             configurators.forEach(configurator -> {
                 if (configurator.apply(config, httpClientBuilder)) {
-                    LOGGER.debug("Successfuly applied " + configurator.getClass().getName()
+                    LOGGER.debug("successfully applied " + configurator.getClass().getName()
                             + " configurator to OpensearchClient");
                 }
             });

src/main/java/io/aiven/kafka/connect/opensearch/OpensearchSinkConnector.java

@@ -54,8 +54,7 @@ public Class<? extends Task> taskClass() {
     @Override
     public List<Map<String, String>> taskConfigs(final int maxTasks) {
         final List<Map<String, String>> taskConfigs = new ArrayList<>();
-        final Map<String, String> taskProps = new HashMap<>();
-        taskProps.putAll(configProperties);
+        final Map<String, String> taskProps = new HashMap<>(configProperties);
         for (int i = 0; i < maxTasks; i++) {
             taskConfigs.add(taskProps);
         }

src/main/java/io/aiven/kafka/connect/opensearch/RetryUtil.java

@@ -115,7 +115,7 @@ public static <T, E extends Exception> T callWithRetry(final String callName, fi
                     final long sleepTimeMs = computeRandomRetryWaitTimeInMillis(retryAttempts, retryBackoffMs);
                     final var msg = String.format("Failed to %s with attempt %s/%s, will attempt retry after %s ms. ",
                             callName, attempts, maxAttempts, sleepTimeMs);
-                    LOGGER.warn(msg + "Failure reason: {}", e);
+                    LOGGER.warn(msg + "Failure reason: ", e);
                     time.sleep(sleepTimeMs);
                 } else {
                     final var msg = String.format("Failed to %s after total of %s attempt(s)", callName, attempts);

src/main/java/io/aiven/kafka/connect/opensearch/spi/ClientsConfiguratorProvider.java

@@ -17,10 +17,8 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Iterator;
 import java.util.ServiceLoader;
 
-import io.aiven.kafka.connect.opensearch.OpensearchSinkConnectorConfig;
 
 public final class ClientsConfiguratorProvider {
     private ClientsConfiguratorProvider() {
@@ -30,19 +28,15 @@ private ClientsConfiguratorProvider() {
      * Use {@link ServiceLoader} mechanism to discover available configurators for Opensearch (and possibly others)
      * clients which are applicable to the provided configuration.
      *
-     * @param config
-     *            provided configuration
      * @return the list of discovered {@link OpensearchClientConfigurator} configurators which are applicable to the
      *         provided configuration.
      */
-    public static Collection<OpensearchClientConfigurator> forOpensearch(final OpensearchSinkConnectorConfig config) {
+    public static Collection<OpensearchClientConfigurator> forOpensearch() {
         final Collection<OpensearchClientConfigurator> configurators = new ArrayList<>();
         final ServiceLoader<OpensearchClientConfigurator> loaders = ServiceLoader
                 .load(OpensearchClientConfigurator.class, ClientsConfiguratorProvider.class.getClassLoader());
 
-        final Iterator<OpensearchClientConfigurator> iterator = loaders.iterator();
-        while (iterator.hasNext()) {
-            final OpensearchClientConfigurator configurator = iterator.next();
+        for (OpensearchClientConfigurator configurator : loaders) {
             configurators.add(configurator);
         }