Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/missing dep issue 56 #57

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Bug/missing dep issue 56 #57

merged 2 commits into from
Oct 9, 2023

Conversation

inifares23lab
Copy link
Contributor

@inifares23lab inifares23lab commented Oct 8, 2023 •
edited
Loading

About this change - What it does

  • adds numpy as a dependency to requirements.txt
  • updates gitignore for who uses pylsp-rope

Resolves: #56

Why this way

  • because having deps in requirements.txt is the standard
  • update gitignore in this same PR as it doesn't seem to be worth opening a new PR

ftisiot
ftisiot approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@ftisiot ftisiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ftisiot ftisiot merged commit b5585ad into Aiven-Open:main Oct 9, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftisiot ftisiot ftisiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing numpy in requirements.txt
2 participants
@inifares23lab @ftisiot