Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jjaakola aiven rebase main gh actions run #1029

Closed
wants to merge 80 commits into from
Closed

Jjaakola aiven rebase main gh actions run #1029

wants to merge 80 commits into from

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

References: #xxxxx

Why this way

jjaakola-aiven and others added 30 commits January 23, 2025 13:03
@jjaakola-aiven
chore: pip-compile to upgrade requirements
fdf749b
@jjaakola-aiven
chore: upgrade requirement versions
a6feae5
@jjaakola-aiven
wip: Karapace SR runs on FastAPI
6be18b2
@jjaakola-aiven
fix: omit null fields in schema get response
5c27da3
@jjaakola-aiven
fix: healthcheck response type, interactive doc works
1b8bc9e
@jjaakola-aiven
fix: tests/integration/test_schema.py passes
13ccb05
@jjaakola-aiven
chore: remove trail from test_schema.py integration test
acfa765
@jjaakola-aiven
fix: healthcheck corrected
591fcd8
@jjaakola-aiven
chore: remove trail from test_schema_registry_mode.py
e32a03e
@jjaakola-aiven
fix: corrected test_karapace.py test
73ecbf7
@jjaakola-aiven
fix: test_schema_reader.py integration test corrected
43419b6
@jjaakola-aiven
fix: added reference support for protobuf back
022d3b8
@jjaakola-aiven
fix: depencies integration test corrected
4bb80db
@jjaakola-aiven
fix: corrected master coordinator test
6a76335
@jjaakola-aiven
fix: add missing root router file
e5ebb45
@jjaakola-aiven
fix: add missing content type and errors files
5ada334
@jjaakola-aiven
fix: added forwarding back
dc9ff78
@jjaakola-aiven
fix: fixed remote client test
de32c70
@jjaakola-aiven
chore: added missing license headers
a529e30
@jjaakola-aiven
fix: basic and no authentication integrated
b6bd89c
@jjaakola-aiven
fix: fixed schema response to have schemaType
d707b6f
@jjaakola-aiven
fix: run Karapace as a module, __main__
3e85598
@jjaakola-aiven
fix: corrected backup tests
0835bc0
@jjaakola-aiven
wip: Karapace SR runs on FastAPI
681fec0
@jjaakola-aiven
fix: added reference support for protobuf back
78ec164
@jjaakola-aiven
fix: added forwarding back
b5a505f
@jjaakola-aiven
fix: basic and no authentication integrated
79ca8a3
@nosahama @jjaakola-aiven
feat: move schema-registry to own module with DI
70c8f24 
- we create a standalone module for SR related components

- we use DI to wire together the SR dependencies

- we move the routers to own folder

- we move the config initialization to DI and app startup
@nosahama @jjaakola-aiven
chore: drop manual dependencies in-favour of DI
a68f266
@nosahama @jjaakola-aiven
chore: fix config and set defaults
d95de9b
nosahama and others added 26 commits January 23, 2025 13:04
@nosahama @jjaakola-aiven
tracing: inject into __init__.py rather than methods
464b785 
- this still relies on DI wiring, but avoids changing function signatures

- API routes are injected and wired as normal
@nosahama @jjaakola-aiven
ci: extract version from git tags
b1a16a4
@nosahama @jjaakola-aiven
di: do not wire core karapace
0417187
@jjaakola-aiven
chore: make tracer a private member
a0dd281
@nosahama @jjaakola-aiven
chore: dropped span.add_event() usage
ce79c32 
- we realised that this causes a lot of bloat in the console output and isn't actually used yet
@nosahama @jjaakola-aiven
tracer: added noop exporter support
e26ba35
@jjaakola-aiven
chore: resolve otel version from import
dfa9828
@jjaakola-aiven
chore: use ruff
634e497
@jjaakola-aiven
chore: format with ruff
0b156f5
@jjaakola-aiven
chore: remove pylint
273b94d
@jjaakola-aiven
fix: use server host and port instead of host header values
692f37c
@nosahama @jjaakola-aiven
logging: cconfigure FastAPI logging
230e39f
@nosahama @jjaakola-aiven
tests: test configure logging
fe97ed7
@jjaakola-aiven
fix: max http request size for Karapace REST
9812687
@jjaakola-aiven
fix: no forwarding if primary url own
778b4c9
@jjaakola-aiven
chore: don't wait for primary on lifespan
76c9ec1
@jjaakola-aiven
fix: rejoin always when dropped from coordinator
bfede41
@jjaakola-aiven
fix: max request size always set to aio app
2173e30
@nosahama @jjaakola-aiven
gha: use docker layer caching
0c31e6b
@jjaakola-aiven
fix: backup tool shall still use the JSON config file
9a03a43 
The config for backup tool is still the full Karapace config. Config
for Karapace is a set of environment variables opposed to prior
JSON file. Backup tool will still use the JSON format.
@nosahama @jjaakola-aiven
feat: OTel metrics metering
4068d9b
@nosahama @jjaakola-aiven
metering: add middleware for HTTP metrics
4a66266
@nosahama @jjaakola-aiven
metrics: extract metric objects from meter
21a8e86
@nosahama @jjaakola-aiven
metrics: scope http requests metrics
5f04e8c
@nosahama @jjaakola-aiven
metrics: added noop exporter
b840de3
@nosahama @jjaakola-aiven
gha: use docker targets
0702364 
- we drop the `Dockerfile.dev`
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-rebase-main-gh-actions-run branch from 8746351 to 0702364 Compare January 23, 2025 11:07
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/karapace
  config.py 32-33, 149, 178-182, 212, 311, 315, 320, 328-345, 350-351
  content_type.py 6-66
  karapace_all.py 8-14, 21-39, 46-47
  logging_setup.py 22, 38-45
  rapu.py 293-297, 344, 399
  statsd.py 86
  utils.py 32, 200, 238
  src/schema_registry
  __main__.py 6-68
  controller.py 75, 78-96, 100, 119-144, 155-175, 190-191, 201-206, 209-211, 221, 231-232, 240, 242, 244, 246, 265-288, 291, 296, 303-315, 324-342, 356-368, 375-376, 385-393, 401-430, 447-477, 486-540, 548-562, 576-600, 608-613, 625, 649-684, 694-782, 799-869, 874, 881-889, 892-895, 898-909, 918-941
  factory.py 6-67
  messaging.py 55, 109
  reader.py 210, 228, 256-257, 327, 350, 378-381
  registry.py 75, 98-107, 113
  user.py 19-30
  src/schema_registry/http_handlers
  __init__.py 6-28
  src/schema_registry/middlewares
  __init__.py 6-37
  src/schema_registry/routers
  compatibility.py 6-37
  config.py 33-36, 51, 72-75, 90-98, 114-122
  health.py 6-86
  master_availability.py 6-60
  metrics.py 6-23
  mode.py 6-48
  schemas.py 6-91
  setup.py 6-27
  subjects.py 6-206
Project Total  

The report is truncated to 25 files out of 85. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven deleted the jjaakola-aiven-rebase-main-gh-actions-run branch January 23, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjaakola-aiven @nosahama