Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle urlencoded forward slash in subject #1028

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat: handle urlencoded forward slash in subject #1028

merged 2 commits into from
Jan 24, 2025

Conversation

jjaakola-aiven
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven commented Jan 22, 2025 •
edited
Loading

About this change - What it does

Adds support for url encoded forward slashes in subject names.
See: encode/starlette#826
See: fastapi/fastapi#7328 (comment)

References: #xxxxx

Why this way

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch 3 times, most recently from 66b4d52 to 715fe6a Compare January 22, 2025 07:52
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch 3 times, most recently from bd954fc to 292b99c Compare January 22, 2025 08:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/karapace
  client.py
  src/schema_registry/routers
  compatibility.py 13-17, 37
  config.py 76, 95, 120
  mode.py 13-17, 48
  raw_path_router.py 30-44
  subjects.py 15-19, 60, 84, 110, 134, 151, 171, 194, 210
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch from a99894d to 51ae4cb Compare January 23, 2025 08:44
@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review January 23, 2025 08:44
@jjaakola-aiven jjaakola-aiven requested review from a team as code owners January 23, 2025 08:44
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch from 51ae4cb to dd6c1e2 Compare January 23, 2025 15:00
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch 2 times, most recently from 0038fe3 to 002e84b Compare January 24, 2025 12:09
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch from 002e84b to 2876794 Compare January 24, 2025 12:29
nosahama
nosahama approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@nosahama nosahama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nosahama nosahama merged commit b21230c into jjaakola-aiven-fastapi Jan 24, 2025
10 checks passed
@nosahama nosahama deleted the jjaakola-aiven-handle-urlencoded-forward-slash-in-subject branch January 24, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nosahama nosahama nosahama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjaakola-aiven @nosahama