feat: OTel metrics & metering #1011
Open
+232
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosahama
force-pushed
the
nosahama/EC-681/otel-metrics
branch
3 times, most recently
from
e06b32e to
7c9d0c6
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nosahama
force-pushed
the
nosahama/EC-681/otel-metrics
branch
2 times, most recently
from
1b21afc to
944a4f1
Compare
nosahama
force-pushed
the
nosahama/EC-681/otel-metrics
branch
from
944a4f1 to
efe2e90
Compare
nosahama
force-pushed
the
nosahama/EC-681/otel-metrics
branch
from
efe2e90 to
df31d0e
Compare
| ) -> Response: | ||
| resource = request.url.path.split("/")[1] | ||
| with tracer.get_tracer().start_as_current_span(name=f"{request.method}: /{resource}", kind=SpanKind.SERVER) as span: | ||
| span.add_event("Creating metering resources") | ||
| karapace_http_requests_in_progress: UpDownCounter = meter.get_meter().create_up_down_counter( |
There was a problem hiding this comment.
Is this creating the counter or reusing the existing one? Similar question for the duration histogram and requests counter.
| tracer.update_span_with_request(request=request, span=span) | ||
| span.add_event("Calling request handler") | ||
| response: Response = await call_next(request) |
There was a problem hiding this comment.
If call to next fails, are the subsequent calls to tracer and meters called?
| setattr(request.state, meter.START_TIME_KEY, time.monotonic()) | ||
|
|
||
| # Extract request labels | ||
| path = request.url.path |
There was a problem hiding this comment.
This will create quite large cardinality when Karapace handles large number of topics and versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
prometheusvia theopentelemetry-collectoras shown belowgrafanadashboard shows that theprometheussource still works as expectedFollow up
schema_readermetrics to use the OTel meterstatsd