Remove FastAPI dependency #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelynch
force-pushed
the
joelynch/fastapi
branch
from
0caf16f to
92050fc
Compare
FastAPI does not suit our needs as our routes do not return pydantic models, they return MsgSpec Structs. Additionally, we do not make use of schema generation. Instead, we can thinly wrap Starlette ourselves.
joelynch
force-pushed
the
joelynch/fastapi
branch
from
92050fc to
06c1a86
Compare
kmichel-aiven
requested changes
Oct 17, 2024
There was a problem hiding this comment.
I'm not sure keeping a decorator-based approach is really necessary, that's more code and complexity than just building the routers with direct calls. I don't think it's worth writing half a custom framework.
The other related aspect is that starlette.py isn't tested, so making it much smaller and directly testing it would be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastAPI does not suit our needs as our routes do not return pydantic models, they return MsgSpec Structs. Additionally, we do not make use of schema generation. Instead, we can thinly wrap Starlette ourselves.