Merge pull request #496 from AikidoSec/replace-makefile

Use npm run instead of Makefile

.github/CONTRIBUTING.md

@@ -5,6 +5,7 @@ First off, thanks for taking the time to contribute! ❤️
 All types of contributions are encouraged and valued. See the [Table of Contents](#table-of-contents) for different ways to help and details about how this project handles them. Please make sure to read the relevant section before making your contribution. It will make it a lot easier for us maintainers and smooth out the experience for all involved. The community looks forward to your contributions. 🎉
 
 > And if you like the project, but just don't have time to contribute, that's fine. There are other easy ways to support the project and show your appreciation, which we would also be very happy about:
+>
 > - Star the project
 > - Tweet about it
 > - Refer this project in your project's readme
@@ -64,7 +65,7 @@ We use GitHub issues to track bugs and errors. If you run into an issue with the
 
 - Open an [Issue](https://github.com/AikidoSec/firewall-node/issues/new). (Since we can't be sure at this point whether it is a bug or not, we ask you not to talk about a bug yet and not to label the issue.)
 - Explain the behavior you would expect and the actual behavior.
-- Please provide as much context as possible and describe the *reproduction steps* that someone else can follow to recreate the issue on their own. This usually includes your code. For good bug reports you should isolate the problem and create a reduced test case.
+- Please provide as much context as possible and describe the _reproduction steps_ that someone else can follow to recreate the issue on their own. This usually includes your code. For good bug reports you should isolate the problem and create a reduced test case.
 - Provide the information you collected in the previous section.
 
 Once it's filed:
@@ -96,12 +97,12 @@ Enhancement suggestions are tracked as [GitHub issues](https://github.com/Aikido
 ### Your First Code Contribution
 
 - clone the repository to your local machine
-- run `$ make install` to install dependencies
-- run `$ make build` to build the library
-- run `$ make watch` to watch for changes and rebuild the library
-- run `$ make test` to run tests using tap
-- run `$ make end2end` to run end-to-end tests using tap
-- run `$ make lint` to run ESLint
+- run `$ npm install` to install dependencies
+- run `$ npm run build` to build the library
+- run `$ npm run watch` to watch for changes and rebuild the library
+- run `$ npm t` to run tests using tap
+- run `$ npm run end2end` to run end-to-end tests using tap
+- run `$ npm run lint` to run ESLint
 
 ## Styleguides
 

.github/workflows/benchmark.yml

@@ -39,8 +39,8 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y wrk
-      - run: make install
-      - run: make build
+      - run: npm install
+      - run: npm run build
       - name: Run NoSQL Injection Benchmark
         run: cd benchmarks/nosql-injection && AIKIDO_CI=true node benchmark.js
       - name: Run SQL Injection Benchmark

.github/workflows/build-and-release.yml

@@ -27,16 +27,16 @@ jobs:
           registry-url: "https://registry.npmjs.org"
           scope: "@aikidosec"
       - name: Install dependencies
-        run: make install
+        run: npm install
       - name: Get the version
         id: get_version
         run: echo "tag=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
       - name: Set the version
         run: cd library && npm --no-git-tag-version version ${{ steps.get_version.outputs.tag }}
       - name: Build the library
-        run: make build
+        run: npm run build
       - name: Linting
-        run: make lint
+        run: npm run lint
       - name: Publish to NPM
         run: |
           if [ "${{ github.event.release.prerelease }}" = "true" ]; then

.github/workflows/end-to-end-tests.yml

@@ -63,6 +63,6 @@ jobs:
       - name: Build and run server
         run: |
           cd end2end/server && docker build -t server . && docker run -d -p 5874:3000 server
-      - run: make install
-      - run: make build
-      - run: make end2end
+      - run: npm install
+      - run: npm run build
+      - run: npm run end2end

.github/workflows/lint-code.yml

@@ -14,6 +14,6 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: "npm"
           cache-dependency-path: "**/package-lock.json"
-      - run: make install-lib-only
-      - run: make build
-      - run: make lint
+      - run: npm run install-lib-only
+      - run: npm run build
+      - run: npm run lint

.github/workflows/unit-test.yml

@@ -76,9 +76,9 @@ jobs:
       - name: Add local.aikido.io to /etc/hosts
         run: |
           sudo echo "127.0.0.1 local.aikido.io" | sudo tee -a /etc/hosts
-      - run: make install-lib-only
-      - run: make build
-      - run: make test-ci
+      - run: npm run install-lib-only
+      - run: npm run build
+      - run: npm run test:ci
       - name: "Upload coverage"
         uses: codecov/[email protected]
         with:

.nvmrc

@@ -1 +1 @@
-20.11
+22.12

benchmarks/sql-injection/benchmark.js

@@ -1,8 +1,6 @@
 /**
  * Runs benchmarks for the detection of SQL Injections
  */
-const fs = require("fs");
-const { join } = require("path");
 const {
   detectSQLInjection,
 } = require("../../build/vulnerabilities/sql-injection/detectSQLInjection");