Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Format Script #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding Format Script #115

wants to merge 1 commit into from

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Jan 8, 2025

No description provided.

@amessbee amessbee self-assigned this Jan 8, 2025
Copy link
Member

@mujahidkay mujahidkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would also help to add a prettierrc. We can configure it to format jsdoc and shell scripts as well.

"node_modules"
]
}
"compilerOptions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a prettierignore that ignores all json files except package.json (see this for ref)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Do we have .prettierrc in any repo that we can copy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we take a look at the one in agoric-sdk but its not applicable as is. We can use relevant portions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants