test: fixed flake due to smart wallet required dialog #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dapp-inter-test with
|
| Latest commit: |
a1453b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b107405.dapp-inter-test.pages.dev |
| Branch Preview URL: | https://fraz-test-smart-wallet-dialo.dapp-inter-test.pages.dev |
Deploying agoric-dapp-inter-emerynet with
|
| Latest commit: |
a1453b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3951bbd.agoric-dapp-inter-emerynet.pages.dev |
| Branch Preview URL: | https://fraz-test-smart-wallet-dialo.agoric-dapp-inter-emerynet.pages.dev |
frazarshad
added
liquidation-reconstitution-testing
| @@ -194,6 +194,7 @@ const connectWalletLocalChain = ({ isVaultsTests = false }) => { | |||
| }; | |||
|
|
|||
| const connectWalletTestnet = () => { | |||
| cy.contains('button', 'Dismiss').click(); | |||
| cy.get('button').contains('Local Network').click(); | |||
There was a problem hiding this comment.
I think this might trouble with Liquidation tests.
There was a problem hiding this comment.
It's my bad for not realizing we're using the same function in Vault tests.
chore: if condition specifically for vault tests
frazarshad
removed
the
liquidation-reconstitution-testing
rabi-siddique
approved these changes
Oct 23, 2024
|
LGTM. The one test case failing in liquidation tests is not related to the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates test to fix issue with "Smart wallet required" dialog box sometimes appearing if provisioning from the faucet takes too long