Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/rtc ng/4.4.0 #3700

Merged
merged 19 commits into from
Jul 12, 2024
Merged

Release/rtc ng/4.4.0 #3700

merged 19 commits into from
Jul 12, 2024

Conversation

Cilla-luodan
Copy link
Collaborator

No description provided.

@@ -88,15 +88,16 @@
<ul>
<li props="android">Optimized parameter types for the following APIs to enhance code readability, reduce potential errors, and facilitate future maintenance:
<ul>
<li>Deprecated <codeph>option</codeph> parameter of type int in <apiname keyref="setRemoteSubscribeFallbackOption"/>, introduced overloaded function <apiname keyref="setRemoteSbscribeFallbackOption2"/> with <codeph>option</codeph> parameter of type <apiname keyref="STREAM_FALLBACK_OPTIONS"/>.</li>
<li>Deprecated <codeph>option</codeph> parameter of type int in <apiname keyref="setRemoteSubscribeFallbackOption"/>, introduced overloaded function <apiname keyref="setRemoteSubscribeFallbackOption2"/> with <codeph>option</codeph> parameter of type <apiname keyref="STREAM_FALLBACK_OPTIONS"/>.</li>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有 bug fix 里用一般过去式,其他地方都应该是一般现在时

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 gpt 贴过来的翻译,并没有改内容,只是在修发布报错。你可以晚点等大家都改好了再加 comment 哦。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一轮就是 check 并编辑自己负责的内容+改报错……

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我知道啊,但是大家都还没有编辑完,晚点 ready for review 了再 comment 哦,别急

@Cilla-luodan Cilla-luodan merged commit df0d6cb into master Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants