4.2.4 bugfix 1102 #3408
Merged
4.2.4 bugfix 1102 #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cilla-luodan
commented
Nov 1, 2023
| @@ -34,7 +34,7 @@ | |||
| <note type="attention"> | |||
| <ul> | |||
| <li props="cpp unreal bp unity flutter cs">该方法仅适用于 Android 和 iOS。</li> | |||
| <li>该方法必须在开启摄像头后调用，如 <xref keyref="startPreview2"/> 和 <xref keyref="enableVideo" /> 后调用。</li> | |||
| <li>该方法必须在开启摄像头前调用，如 <xref keyref="startPreview2"/> 和 <xref keyref="enableVideo" /> 后调用。</li> | |||
There was a problem hiding this comment.
话说这里感觉有些疑惑，因为调用了 startPreview 和 enableVideo 后就开启了摄像头，那么zhongyang 所说的必须在开启摄像头“前”调用到底是个什么时机……难道要在 startPreview 和 enableVideo 之前就调用么
There was a problem hiding this comment.
感觉注释这个更清晰一些，具体是在开启本地摄像头采集的时候
Cilla-luodan
commented
Nov 1, 2023
Cilla-luodan
commented
Nov 1, 2023
Cilla-luodan
commented
Nov 1, 2023
| </ul> </note> </section> | ||
| <ul> | ||
| <li>调用该方法后，在收到 <apiname keyref="onLastmileQuality" /> 和 <apiname keyref="onLastmileProbeResult" /> 回调之前请不要调用其他方法，否则可能会由于 API 操作过于频繁导致此方法无法执行。</li> | ||
| <li>在直播场景中，如果本地用户为主播，请勿加入频道后调用该方法。</li> |
There was a problem hiding this comment.
这里的描述优化一下可好？与其说“请勿xxx”，不如直接说推荐如何操作。
…ce into 4.2.4-bugfix-1102
jinyuagora
reviewed
Nov 1, 2023
| <section id="return_values"> | ||
| <title>返回值</title> | ||
| <p><ph>设置 SDK 输出的原始数据格式。</ph><ph props="cpp unreal bp ios mac unity">详见 <xref keyref="VIDEO_PIXEL_FORMAT" props="cpp unreal bp ios mac"/><xref keyref="VIDEO_OBSERVER_FRAME_TYPE" props="unity"/>。</ph></p> | ||
| <p><ph>设置 SDK 输出的原始数据格式。</ph><ph props="cpp unreal bp ios mac unity">详见 <xref keyref="VIDEO_PIXEL_FORMAT" props="cpp unreal bp ios mac"/><xref keyref="VIDEO_OBSERVER_FRAME_TYPE" props="unity"/>。</ph></p> |
There was a problem hiding this comment.
甚至特意给unity写了，不过unity这个callback_ivideoframeobserver_getvideoformatpreference似乎没放出来
There was a problem hiding this comment.
对的，写完后查到框架都没有，忘了干掉它
jinyuagora
reviewed
Nov 1, 2023
| <li props="mac cpp unreal bp electron unity flutter">macOS：YUV 420</li> | ||
| <li props="android cpp unreal bp rn unity flutter">Android：I420 或 RGB 纹理格式</li> | ||
| <li props="ios cpp unreal bp rn unity flutter">iOS：I420 或 CVPixelBufferRef</li> | ||
| <li props="mac cpp unreal bp electron unity flutter">macOS：I420 或 CVPixelBufferRef</li> | ||
| <li props="cpp unreal bp electron unity flutter cs">Windows：YUV 420</li></ul></note></pd> |
There was a problem hiding this comment.
YUV420、YUV422 这些带不带空格有统一的写法不？
Cilla-luodan
commented
Nov 1, 2023
Cilla-luodan
commented
Nov 1, 2023
| @@ -50,11 +50,38 @@ | |||
| </plentry> | |||
| <plentry> | |||
| <pt>deviceType</pt> | |||
| <pd>设备类型定义。详见 <xref keyref="MEDIA_DEVICE_TYPE"/>。</pd> | |||
| <pd props="unity cs flutter electron">设备类型定义。详见 <xref keyref="MEDIA_DEVICE_TYPE"/>。</pd> | |||
There was a problem hiding this comment.
这里应该不用改，因为对于 cpp 来说，对应 deviceType 本来就是有一个枚举类的，通用的写法就是原有的这样。
Cilla-luodan
commented
Nov 1, 2023
| <plentry> | ||
| <pt>deviceState</pt> | ||
| <pd props="unity cs flutter">设备状态，详见 <xref keyref="MEDIA_DEVICE_STATE_TYPE"/>。</pd> | ||
| <pd props="cpp unreal electron">设备状态。 |
There was a problem hiding this comment.
同上，CPP 的这里是要详见到 MEDIA_DEVICE_STATE_TYPE 的，只是 OC 里没有对应的枚举类，所以需要针对 mac 直接把值写出来。
There was a problem hiding this comment.
这个文件可以不用管mac，mac用的是statechanged那个文件
Cilla-luodan
commented
Nov 1, 2023
dita/RTC-NG/API/callback_irtcengineeventhandler_onvideodevicestatechanged.dita
Outdated
Show resolved
Hide resolved
…doc_source into 4.2.4-bugfix-1102
…ce into 4.2.4-bugfix-1102
…doc_source into 4.2.4-bugfix-1102
…doc_source into 4.2.4-bugfix-1102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.