Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auikaraoke #3336
auikaraoke #3336
Changes from 23 commits
5f9b5f0
02b6cff
fb86990
7082c13
d8f33b4
9e25cdd
7dff1f5
9bf0556
aec7642
44aa4de
1e9ead9
be05e01
cb41cf3
d5a377f
ba651ed
9975118
cc63adc
62c6cda
bf37391
c2c343c
2ee96f0
7bf3ee1
e9ab5a6
4c675ba
bb982fb
7779db1
c9e51b9
44f7838
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为是获取房间列表的接口,或许改为:
获取房间列表的起始时间。传递一个时间戳作为起始时间,用于筛选在该时间之后创建的房间。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
startTime 是一个需要填的参数,改为“获取房间列表的起始时间”感觉有点不太对?
改为:房间创建的时间,用于筛选在该时间之后创建的房间?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上指用户 —> 上指定用户?
不懂就问 - 这个是创建房间的时候配置的信息,是不是创建房间的用户默认就是房主?那这里是创建者头像的 URL 么?还是说创建的时候就能指定是哪个用户。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个看数据类型是 String,想问具体支持哪些排列样式、可以传入哪些字符串?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看你其他的 api 都是把一句话描述写在原型下面,这个要不要保持一致也挪下去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看注释的话这个
rtcRtmToken
只能用 006,估计还要提示一下确保使用的是 AccessToken,我裂开。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个后来跟研发确认 rtm 006、007 都可以用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你小子又是 006 还是 007。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果⚠️ 加太多了可能也起不到⚠️ 的作用了,或许就给一条,5 个 Token 里哪几个用 006 哪几个用 007 一条 note 讲完。。做个对比区分
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更新之后应该只有登录rtm系统用的rtm和rtc需要用007,其他的二者都可