-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync from release/6.3 #2169
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peilinok
force-pushed
the
dev/release/6.2
branch
from
December 24, 2024 10:17
98be861
to
da0949e
Compare
Cleanup some unused permissions following the https://docs.agora.io/en/video-calling/get-started/get-started-sdk?platform=android#project-setup
Clear context current after rendering op to avoid reuse of the same gl context on a different thread, this is a change for the native sdk 4.3.0, the callback thread may be from a different thread after native sdk 4.3.0.
…1543) We get the texture id from the `VideoViewController` that is passed by the user directly, which will be reset if the widget is updated, so we need to maintain it internally.
Fix some ci issues that block the #1572 - iOS simulator not be created in the rendering test, it is most likely there's no "iPhone 13 Pro Max" in the `macos-12` runner anymore. - The rendering test for the web failed with Flutter SDK 3.19, will fix it later.
On iOS low power mode, the system force keeps the screen on for 30s only, we keep the screen on to help internal testing.
Add action to run the `tool/terra` on CI
Need more configurations to make it work.
This PR fixes #1657 by tweaking the `pubspec.yaml` file. Once this change is implemented, developers who use this plugin won't be prevented from using new linting features.
After hardware accelerated support on Ubuntu, we can move the integration test and rendering test to Ubuntu to save the test times. https://github.blog/changelog/2024-04-02-github-actions-hardware-accelerated-android-virtualization-now-available/
…22 (#1777) Some tests failed after upgrading the Flutter SDK 3.22, see https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK/actions/runs/9177683376/job/25235867951?pr=1774 - Remove the use of `Theme.of(context).textTheme.headline4`. - We previously added the `iris_web_version.js` as assets, and let the Flutter SDK copy the `iris_web_version.js` to the web folder, which does not work on Windows with Flutter SDK 3.22. We now copy the `iris_web_version.js` before running the test explicitly. - The method channel call of `destroyTextureRender ` does not be mocked - Remove the `FakeMethodChannelController.dispose`, which may reset the mock `MethodChannelCallHandler` too early, which caused an error on Windows(We checked the texture id can not be 0 on Windows).
The code only matches the 3-segment version, but the native SDK can be 2-segment or 4-segment.
Fix build-iris-ios.sh not work for the newest iris's changes.
Adapt foreground service changes on Android 14. https://developer.android.com/about/versions/14/changes/fgs-types-required Fix #1783
The main branch will support the dart records features, which require the dart SDK >= 3.0.0, so we pin the `paraphrase` to avoid a break change. littleGnAl/paraphrase#1
We want the job to keep running although the other job has failed in the `matrix`. Refer https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Upgrade iris_method_channel to version ^2.2.0 to ensure compatibility with the 2.x.
If the `AgoraVideoView` is disposed of before the `_initializeTexture` is completed, it will cause an NPE.
Flutter 3.22 had dropped support for Android KitKat https://docs.flutter.dev/release/breaking-changes/android-kitkat-deprecation, update minSdkVersion to 21 to Fix NDK Compatibility Issue.
…on for AGP 8.x (#2050) Suppress `ERROR: R8: Missing class com.google.devtools.build.android.desugar.runtime.ThrowableExtension` when running with AGP 8.x The Android Native SDK has caught this error internally, so we're safe to suppress this error. Fix failed job https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK/actions/runs/11359234733/job/31595029855?pr=2049
Cover the customer's scenario #1832 (comment)
…ize handling (#2052) The `resize` value from `OnVideoFrameReceived` became invalid after the recent `iris` refactor(>= 4.3.2). We now manage the resize check internally to prevent black screens in `AgoraVideoView`.
Co-authored-by: gxz <[email protected]>
…gration test app for ios
…it (#2055) If an `AgoraVideoView` is displayed and a video frame callback is received while the app is quitting, there is a potential crash risk due to access to invalid resources(invalid adresses) in the callback. To prevent this, we should ensure that resources are properly cleaned up in the destructor. This logic is already handled in the Windows implementation, so in this PR, we are updating it for Android, iOS, and macOS only.
This reverts commit 6ff4ffd.
peilinok
force-pushed
the
dev/release/6.2
branch
from
December 25, 2024 08:08
8f862a6
to
d383b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.