++

AgoraIO-Extensions · Oct 12, 2024 · feb60b1 · feb60b1
1 parent 985c67a
commit feb60b1
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 28 deletions.
diff --git a/lib/src/bindings/agora_rtm_client_impl_override.dart b/lib/src/bindings/agora_rtm_client_impl_override.dart
@@ -228,10 +228,11 @@ class RtmClientImplOverride extends rtmc_binding.RtmClientImpl {
       required String message,
       required int length,
       required PublishOptions option}) async {
+    final messageUint8List = Uint8List.fromList(utf8.encode(message));
     return publishBinaryMessage(
         channelName: channelName,
-        message: Uint8List.fromList(utf8.encode(message)),
-        length: length,
+        message: messageUint8List,
+        length: messageUint8List.length,
         option: option);
   }
 }
diff --git a/lib/src/bindings/agora_stream_channel_impl_override.dart b/lib/src/bindings/agora_stream_channel_impl_override.dart
@@ -44,10 +44,11 @@ class StreamChannelImpl extends sci_binding.StreamChannelImpl
       required String message,
       required int length,
       required TopicMessageOptions option}) async {
+    final messageUint8List = Uint8List.fromList(utf8.encode(message));
     return publishBinaryMessage(
         topic: topic,
-        message: Uint8List.fromList(utf8.encode(message)),
-        length: length,
+        message: messageUint8List,
+        length: messageUint8List.length,
         option: option);
   }
 
@@ -57,10 +58,11 @@ class StreamChannelImpl extends sci_binding.StreamChannelImpl
       required String message,
       required int length,
       required TopicMessageOptions option}) {
+    final messageUint8List = Uint8List.fromList(utf8.encode(message));
     return publishBinaryMessage(
         topic: topic,
-        message: Uint8List.fromList(utf8.encode(message)),
-        length: length,
+        message: messageUint8List,
+        length: messageUint8List.length,
         option: option);
   }
 }
diff --git a/lib/src/impl/agora_rtm_client_impl_override.dart b/lib/src/impl/agora_rtm_client_impl_override.dart
@@ -222,17 +222,6 @@ class RtmClientImplOverride extends rtm_client_impl.RtmClientImpl {
       String channelName, String message,
       {RtmChannelType channelType = RtmChannelType.message,
       String? customType}) async {
-    // final option = PublishOptions(
-    //     channelType: channelType,
-    //     messageType: RtmMessageType.string,
-    //     customType: customType);
-    // final requestId = await nativeBindingRtmClientImpl.publish(
-    //     channelName: channelName,
-    //     message: message,
-    //     length: message.length,
-    //     option: option);
-    // return rtmResultHandler.request(requestId);
-
     final option = PublishOptions(
         channelType: channelType,
         messageType: RtmMessageType.string,
@@ -260,17 +249,6 @@ class RtmClientImplOverride extends rtm_client_impl.RtmClientImpl {
       String channelName, Uint8List message,
       {RtmChannelType channelType = RtmChannelType.message,
       String? customType}) async {
-    // final option = PublishOptions(
-    //     channelType: channelType,
-    //     messageType: RtmMessageType.binary,
-    //     customType: customType);
-    // final requestId = await nativeBindingRtmClientImpl.publishBinaryMessage(
-    //     channelName: channelName,
-    //     message: message,
-    //     length: message.length,
-    //     option: option);
-    // return rtmResultHandler.request(requestId);
-
     final option = PublishOptions(
         channelType: channelType,
         messageType: RtmMessageType.binary,

diff --git a/test_shard/integration_test_app/test/agora_rtm_client_impl_override_test.dart b/test_shard/integration_test_app/test/agora_rtm_client_impl_override_test.dart
diff --git a/test_shard/integration_test_app/test/agora_stream_channel_impl_override_test.dart b/test_shard/integration_test_app/test/agora_stream_channel_impl_override_test.dart