Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _more_ tests for field, group, annotate and addField methods and improve coverage by 7% #7

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Add _more_ tests for field, group, annotate and addField methods and improve coverage by 7% #7

merged 4 commits into from
Oct 28, 2023

Conversation

mahdihaghverdi
Copy link
Contributor

What's Changed

Overall coverage is improved by 7% (76% to 83%)

Added

  • Added a test for raised ValueError in field method
  • Added tests for group method
  • Added many tests for annotated method
  • Added a test for raised ValueError in addField method

Fixed

  • annoated now returns the self

@mahdihaghverdi
Copy link
Contributor Author

@mohamadkhalaj please review the changes in annotated

@seyed-dev seyed-dev merged commit 44a357b into Aggify:main Oct 28, 2023
1 check passed
@mahdihaghverdi mahdihaghverdi deleted the more-tests branch October 28, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahdihaghverdi @seyed-dev