Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/clean-up-sdk #2376

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Dec 13, 2024

Clean up routing decorator in SDK to remove:

  • InFile and ingest (that was a beta feature that was never deployed to prod)
  • Old way of handling config (SDK v2)

What is not cleaned:

  • generate and generate_deployed -> This needs to be done in sync with the FE. Let's have it later

Also added a couple of tests for the service for quick sanity check when doing changes

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:51pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:51pm

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 13, 2024
@mmabrouk mmabrouk merged commit 3e75805 into feat/AGE-1430-new-playground Dec 13, 2024
4 of 7 checks passed
@mmabrouk mmabrouk deleted the refactor/clean-up-sdk branch December 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring SDK size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant