add basic evaluators #1074
Merged
add basic evaluators #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmabrouk
reviewed
Dec 21, 2023
| try: | ||
| evaluation_function = globals()[evaluator_name] | ||
|
|
||
| return evaluation_function(correct_answer, variant_output, *additional_args, **additional_kwargs) |
There was a problem hiding this comment.
I have multiple notes:
- Please note that not all evaluators would require a correct_answer. While some of the evaluators would require inputs. (for instance the AI critic). The current solution does not take care of that.
Maybe another approach is to provide two payload dictionaries to the evaluators. One data, the other config:
data would include all the information needed for evaluation (the data point)
data["prompt"] data["inputs"] data["outputs"]
config would include all the information needed for the evaluator
config["regex"] config["ai_prompt"] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.