Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]: Resolve communication issue between Linux-based variants and backend #1012

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Dec 7, 2023

Related Issue

Closes #1003

@aybruhm aybruhm requested a review from aakrem December 7, 2023 08:39
@mmabrouk mmabrouk requested a review from devgenix December 7, 2023 11:24
@mmabrouk
Copy link
Member

mmabrouk commented Dec 7, 2023

Great work @aybruhm
@devgenix Can you please test whether this still work on macos (nothing is broken in this case). Please test the following:

  • Creating an llm app from UI and then checking the logs in docker (no warning or something weird)
  • Modifying the parameters in the playground dramatically, publishing the variant, then calling the endpoint through curl and checking from the response whether the LLM application is using the right parameters

@aybruhm
Copy link
Member Author

aybruhm commented Dec 10, 2023

Great work @aybruhm
@devgenix Can you please test whether this still work on macos (nothing is broken in this case). Please test the following:

  • Creating an llm app from UI and then checking the logs in docker (no warning or something weird)
  • Modifying the parameters in the playground dramatically, publishing the variant, then calling the endpoint through curl and checking from the response whether the LLM application is using the right parameters

@devgenix, what's the status on this?

Copy link
Contributor

@devgenix devgenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on MacOS

@mmabrouk mmabrouk merged commit 4d5cba7 into main Dec 11, 2023
6 checks passed
@mmabrouk mmabrouk deleted the gh/fix-communication-issue-1003 branch December 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Issue agenta variants in Linux
3 participants