-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Gemini API integration #650
Conversation
- Add GeminiProvider class for tracking Gemini API calls - Support both sync and streaming modes - Track prompts, completions, and token usage - Add test script demonstrating usage Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
…ing in Gemini provider Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
…orting Co-Authored-By: Alex Reibman <[email protected]>
…improve test coverage Co-Authored-By: Alex Reibman <[email protected]>
…dling and event recording Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Devin did good I think, check it out @the-praxs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the integration was done well. Such small integrations can be done with Devin but the maintenance will be the real challenge.
Comments are left to improve the code structure and efficiency. The notebooks should be modified to follow the same structure as the other notebooks.
Docs are absent. They need to be added for a complete integration.
Sometime later would like to have ActionEvent
and ToolEvent
events also if they are supported.
- Add _extract_token_counts helper method - Make error handling consistent with OpenAI provider - Remove redundant session checks - Improve error message formatting - Add comprehensive documentation Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
Co-Authored-By: Alex Reibman <[email protected]>
I would like to state that this was mergeable because I fixed it. |
Fixed method binding issues in GeminiProvider and improved error handling.
Changes:
Tested:
Additional Changes:
Documentation Updates:
Latest Test Results:
Link to Devin run: https://app.devin.ai/sessions/bf5d3093cfb84eac8a046d4c2f6f992e