Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hax and rustc #222

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Update hax and rustc #222

merged 3 commits into from
Jun 5, 2024

Conversation

Nadrieril
Copy link
Member

This is the companion PR to hacspec/hax#690

@Nadrieril
Copy link
Member Author

Nadrieril commented Jun 3, 2024

@msprotz This is a PR that updates the rustc version. Rustc changed some of its code generation as you can see from the test differences. This apparently breaks kyber, do you understand why? The output of eurydice is:

[ INFO charon_lib::export:111] [GCrateData<_, _>::serialize_to_file]: Generated the file: /run/github-runner/charon-ci/charon/charon/kyber-crate/libcrux_kyber.llbc
warning: `libcrux_kyber` (lib) generated 2 warnings (run `cargo fix --lib -p libcrux_kyber` to apply 2 suggestions)
    Finished dev [unoptimized + debuginfo] target(s) in 26.62s
Running eurydice ...
Cannot re-check libcrux_kyber.sampling.sample_from_uniform_distribution_next as valid Low* and will not extract it.  If libcrux_kyber.sampling.sample_from_uniform_distribution_next is not meant to be extracted, consider marking it as Ghost, noextract, or using a bundle. If it is meant to be extracted, use -dast for further debugging.

1️⃣ LLBC ➡️  AST
2️⃣ Cleanup
Warning 4: in the then branch, after the definition of uu____981, in the sequence statement at index 0, after the definition of iter, in top-level declaration libcrux_kyber.sampling.sample_from_uniform_distribution_next, in file libcrux_kyber_common: Malformed input:
subtype mismatch, () (a.k.a. ()) vs bool (a.k.a. bool)
LowStar.Ignore.ignore doesn't go anywhere
File order after topological sort: LowStar_Ignore, core, libcrux_digest, libcrux_kyber_common, libcrux_kyber768
Error: Process completed with exit code 1.

@msprotz
Copy link
Contributor

msprotz commented Jun 3, 2024

Could you try passing --log '*' to Eurydice and seeing where it differs?

@Nadrieril
Copy link
Member Author

kyber main is broken on charon+eurydice main right now so we'll have to debug that first.

@Nadrieril Nadrieril force-pushed the bump-hax branch 2 times, most recently from 63f5ca5 to 4f31ced Compare June 4, 2024 15:36
Nadrieril added 3 commits June 5, 2024 09:36
This adds too much update complexity for little benefit: rust is quite
stable, most tests stay the same from one version to the next.
@Nadrieril Nadrieril merged commit 3f3c013 into AeneasVerif:main Jun 5, 2024
5 checks passed
@Nadrieril Nadrieril deleted the bump-hax branch June 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants