Merge pull request #58 from Aeliot-Tm/fix-tech-debt

Fix tech debt

.github/workflows/php.yml → .github/workflows/automated_testing.yaml

@@ -1,4 +1,4 @@
-name: PHP Composer
+name: Automated Testing
 
 on:
   push:
@@ -65,7 +65,7 @@ jobs:
     steps:
       - uses: 'shivammathur/setup-php@v2'
         with:
-          php-version: '8.0'
+          php-version: 7.4
 
       - uses: actions/checkout@v3
 

composer.json

@@ -37,9 +37,10 @@
   "require-dev": {
     "aeliot-tm/phpunit-codecoverage-baseline": "^2.0",
     "dg/bypass-finals": "^1.1",
-    "friendsofphp/php-cs-fixer": "^3.8",
+    "friendsofphp/php-cs-fixer": "^2.19.3|^3.8",
     "phpstan/extension-installer": "^1.1",
     "phpstan/phpstan": "^1.8",
+    "phpstan/phpstan-phpunit": "^1.3",
     "phpstan/phpstan-symfony": "^1.2",
     "phpunit/phpunit": "^9.5",
     "symfony/dotenv": "^3.4|^4.0|5.0|^6.0",

src/Service/Translator/TranslatorV6P0.php

@@ -14,6 +14,9 @@ public function getCatalogue(string $locale = null): MessageCatalogueInterface
         return $this->getCatalogueInner($locale);
     }
 
+    /**
+     * @return MessageCatalogueInterface[]
+     */
     public function getCatalogues(): array
     {
         return $this->translator->getCatalogues();

tests/Unit/Service/Yaml/KeysParserTest.php

@@ -14,7 +14,7 @@ final class KeysParserTest extends TestCase
     /**
      * @dataProvider getDataForTestGetOmittedKeys
      *
-     * @param string[] $expected
+     * @param array<string,array<string>> $expected
      * @param array<string,array<string>> $localesKeys
      */
     public function testGetOmittedKeys(array $expected, array $localesKeys): void