Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting maxIssuerNumber for Twint via Drop-In configuration #1913

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Dec 4, 2024

Summary

  • The maxIssuerNumber for Twint can now be set when using Drop-In
  • Statically linking the TwintSDK to prevent name clashing when using another library that includes the TwintSDK as well (e.g. Datatrans)

Release notes

- When using Drop-In: The `maxIssuerNumber` for Twint can now be set

Ticket

COIOS-000

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn added the new a pull request that adds a new feature label Dec 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2024
atmamont
atmamont previously approved these changes Dec 4, 2024
@goergisn goergisn dismissed stale reviews from atmamont and github-actions[bot] via 1cd676f December 6, 2024 13:18
github-actions[bot]
github-actions bot previously approved these changes Dec 6, 2024
Package.swift Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Dec 10, 2024
@goergisn goergisn requested a review from atmamont December 10, 2024 10:57
Copy link
Contributor

👀 2 public changes detected

Comparing dropin-twint-configuration to develop


AdyenActions

AdyenActionComponent.Configuration.Twint

❇️ Added

public var maxIssuerNumber: Swift.Int

🔀 Changed

// From
public init(callbackAppScheme: Swift.String)

// To
public init(
  callbackAppScheme: Swift.String,
  maxIssuerNumber: Swift.Int = .max
)

/**
Changes:
- Added parameter `maxIssuerNumber: Swift.Int = .max`
*/

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Copy link

sonarcloud bot commented Dec 10, 2024

@goergisn goergisn marked this pull request as ready for review December 10, 2024 11:37
@goergisn goergisn merged commit 51b82ab into develop Dec 10, 2024
13 of 14 checks passed
@goergisn goergisn deleted the dropin-twint-configuration branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new a pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants