Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding tests for didCancel #1409

Closed
wants to merge 16 commits into from
Closed

chore: Adding tests for didCancel #1409

wants to merge 16 commits into from

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Oct 9, 2023

Summary

  • adding tests to verify didCancel is called

github-actions[bot]
github-actions bot requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Oct 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
View reviewed changes
@goergisn goergisn changed the base branch from develop to fix-apple-pay-dismissal October 9, 2023 13:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@goergisn goergisn closed this Oct 10, 2023
@goergisn goergisn deleted the fix-apple-pay-dismissal-tests branch January 29, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@erenbesel erenbesel erenbesel approved these changes

Assignees
No one assigned
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goergisn @erenbesel