Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added 2-step address lookup #1407

Merged
merged 39 commits into from
Nov 1, 2023
Merged

chore: Added 2-step address lookup #1407

merged 39 commits into from
Nov 1, 2023

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Oct 6, 2023 •
edited
Loading

Summary

For cards, the address lookup feature now supports a 2-step lookup process (for example, used by the Google Maps API):

  • First, it allows providing suggested addresses (that might be incomplete)
  • Then, optionally, it allows making another API request to complete the suggestions.

You must change the callback as follows:

5.3.0 or earlier 5.4.0
.lookup(LookupProvider) .lookup(AddressLookupProvider)

Changes

  • Adds an optional callback that allows completion of an incomplete address (required for GoogleMaps autocompletion API)
  • Moving the logic of address lookup search logic to its own ViewModel

github-actions[bot]
github-actions bot requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn marked this pull request as draft October 11, 2023 08:48
goergisn added 20 commits October 12, 2023 15:33
@goergisn
Fixing tests
d0b7e45
@goergisn
Better documentation
7edb352
@goergisn
Importing UIKit
ecb5e0e
@goergisn
Fixed project config
b957c62
@goergisn
Update AddressLookupViewControllerTests.swift
bac832c
@goergisn
Added type annotation to reduce warnings
649d7c7
@goergisn
Refactoring for troubleshooting
caa0c2a
@goergisn
Update spell-check-excluded-files-list
489c19e
@goergisn
adding mapkit to allow list
7ec65db
@goergisn
Update CardComponentSettingsView.swift
0aecba8
@goergisn
Update AddressLookupViewControllerTests.swift
8c2d45e
@goergisn
Helping the compiler out
a649f0f
@goergisn
temporarily deactivating one test
bf43aca
@goergisn
Update AddressLookupViewControllerTests.swift
71dbc1b
@goergisn
What is going on
53ff564
@goergisn
Small steps
90204b4
@goergisn
Update AddressLookupViewControllerTests.swift
7c03326
@goergisn
Is it the selection handler access
dd80180
@goergisn
Update AddressLookupViewControllerTests.swift
7a53fac
@goergisn
Update AddressLookupViewControllerTests.swift
6444456
github-actions[bot]
github-actions bot previously approved these changes Oct 16, 2023
View reviewed changes
@goergisn goergisn marked this pull request as ready for review October 17, 2023 12:12
@goergisn goergisn requested review from descorp and erenbesel October 17, 2023 12:12
Base automatically changed from list-item-loading to develop October 17, 2023 12:31
@goergisn goergisn dismissed github-actions[bot]’s stale review October 17, 2023 12:31

The base branch was changed.

github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 19, 2023
View reviewed changes
descorp
descorp previously approved these changes Oct 24, 2023
View reviewed changes
@goergisn goergisn dismissed stale reviews from descorp and github-actions[bot] via c38ed10 October 24, 2023 14:55
github-actions[bot]
github-actions bot previously approved these changes Oct 24, 2023
View reviewed changes
@goergisn goergisn requested review from erenbesel and descorp October 31, 2023 12:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication

@goergisn goergisn merged commit a1026c7 into develop Nov 1, 2023
11 checks passed
@goergisn goergisn deleted the advanced-address-lookup branch November 1, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@erenbesel erenbesel erenbesel approved these changes

@descorp descorp Awaiting requested review from descorp

Assignees
No one assigned
Labels
changed a pull request that changed some thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goergisn @descorp @erenbesel