Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ListItem triggered loading state #1406

Merged
merged 14 commits into from
Oct 17, 2023
Merged

chore: ListItem triggered loading state #1406

merged 14 commits into from
Oct 17, 2023

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Oct 6, 2023

Summary

  • Adds a loadingHandler to the ListItem that allows triggering startLoading without a reference to the ListViewController

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn requested a review from erenbesel October 6, 2023 13:46
@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Oct 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 10, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 10, 2023
Adyen/UI/List/ListItem.swift Outdated Show resolved Hide resolved
Adyen/UI/List/ListItem.swift Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@goergisn goergisn requested review from erenbesel and descorp October 17, 2023 12:12
@goergisn goergisn merged commit 75daaa0 into develop Oct 17, 2023
@goergisn goergisn deleted the list-item-loading branch October 17, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants