Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading state overlapping error dialog in drop-in #1895

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix loading state overlapping error dialog in drop-in #1895

wants to merge 4 commits into from

Commits on Nov 19, 2024

  1. Immediately add the loading dialog to the fragment manager 

    This makes sure we are able to always find the loading dialog when we want to dismiss it. Solving an issue where the loading fragment would be presented on top of the error dialog.

COAND-984
    @OscarSpruit
    OscarSpruit committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5bb12b0 View commit details
    Browse the repository at this point in the history

  2. Remove unused progress spinner in gift card bottom sheet 

    COAND-984
    @OscarSpruit
    OscarSpruit committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0f0b40a View commit details
    Browse the repository at this point in the history

  3. Make sure loading state is dismissed before handling result 

    COAND-984
    @OscarSpruit
    OscarSpruit committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    aa2c529 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Add release note 

    COAND-984
    @OscarSpruit
    OscarSpruit committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    dcf1014 View commit details
    Browse the repository at this point in the history