Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Lookup - Display country name instead of country code #1892

Closed
wants to merge 2 commits into from

Conversation

ozgur00
Copy link
Contributor

@ozgur00 ozgur00 commented Nov 13, 2024

Description

Display country name instead of country code in CardView address lookup selected address field.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-1039

@ozgur00 ozgur00 requested a review from a team as a code owner November 13, 2024 12:00
- Address fields that were edited manually no longer lose their state when starting Lookup mode.

## Changed
- In Card Component selected lookup address field, country name is displayed now instead of country code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also check this with docs team?

@ozgur00 ozgur00 force-pushed the fix/address-lookup-country branch 2 times, most recently from 23fc66c to e315441 Compare November 13, 2024 13:17
@ozgur00 ozgur00 added the Fix [PRs only] Indicates a bug fix label Nov 13, 2024
@ozgur00 ozgur00 changed the title Display country name instead of country code in CardView for lookup Address Lookup - Display country name instead of country code Nov 13, 2024
Copy link

✅ No public API changes

Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ozgur00
Copy link
Contributor Author

ozgur00 commented Nov 14, 2024

Closing the PR to further discuss a solution that might include a backend change.

@ozgur00 ozgur00 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants