Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - New GitHub workflow for releasing #1847

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Release - New GitHub workflow for releasing #1847

merged 6 commits into from
Oct 24, 2024

Conversation

araratthehero
Copy link
Contributor

@araratthehero araratthehero commented Oct 21, 2024 •
edited
Loading

Description

  • Allow running the job on a specified branch instead of main
  • Use new Github secrets for publishing the app on maven central
  • Make the Github release draft

Things to do in the future

  • Add a step to verify if the branch name starts with e.g. release/
  • Separate each step into a different job

Checklist

  • PR is labelled
  • Changes are tested manually

COAND-1013

@araratthehero araratthehero added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Oct 21, 2024
@jreij
Copy link
Collaborator

jreij commented Oct 21, 2024

PR base should not be main, the current release process requires develop to be up to date with main so we cannot merge anything directly to main before we are fully ready to remove the old release process

@araratthehero araratthehero changed the base branch from main to develop October 21, 2024 15:13
@araratthehero araratthehero force-pushed the chore/new_github_action_for_releasing branch from 8f9a8bf to 916f436 Compare October 21, 2024 15:13
@araratthehero araratthehero marked this pull request as ready for review October 21, 2024 15:37
@araratthehero araratthehero requested a review from a team as a code owner October 21, 2024 15:37
@araratthehero araratthehero marked this pull request as draft October 22, 2024 08:55
@araratthehero araratthehero force-pushed the chore/new_github_action_for_releasing branch from 865f49c to 261692d Compare October 22, 2024 11:48
@araratthehero araratthehero changed the base branch from develop to chore/release_process_changes October 22, 2024 11:49
@araratthehero araratthehero marked this pull request as ready for review October 22, 2024 11:50
@araratthehero araratthehero marked this pull request as draft October 22, 2024 11:59
@araratthehero araratthehero force-pushed the chore/new_github_action_for_releasing branch from 261692d to 52d0a79 Compare October 22, 2024 12:10
jreij
jreij requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@jreij jreij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge the feature branch we will lose the old release action, can we instead keep it and name it something like old?

@araratthehero araratthehero force-pushed the chore/new_github_action_for_releasing branch 2 times, most recently from 81ab86b to c55b08d Compare October 23, 2024 07:17
@araratthehero araratthehero force-pushed the chore/new_github_action_for_releasing branch 2 times, most recently from 7b3f1b7 to 35e0439 Compare October 23, 2024 09:12
@araratthehero araratthehero marked this pull request as ready for review October 23, 2024 09:12
@github-actions GitHub Actions
Copy link

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@araratthehero araratthehero merged commit 60c4259 into chore/release_process_changes Oct 24, 2024
9 checks passed
@araratthehero araratthehero deleted the chore/new_github_action_for_releasing branch October 24, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreij jreij jreij approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araratthehero @jreij