Minimal changes for changing global to local #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bharathappali <[email protected]>
karianna
requested changes
Feb 24, 2021
| do | ||
| tags="${tags} -t ${repo}:${local_tags[$i]}" | ||
| done | ||
| tags=" -t ${repo}:${tag}" |
There was a problem hiding this comment.
"Is the tags var even referenced anymore?
There was a problem hiding this comment.
Yeah at the time when we call check_build_needed here I do accept that with current changes we can pass expanded_tags instead of tags but the check_build_needed expects string to have format -t repo:tag but expanded_tags has a format of -t repo:tag if we update the check_build_needed not to consider space when formating adopt_image_tag we can completely remove the tags var here.
There was a problem hiding this comment.
Your call - I think either leave a comment explaining why they're different or make that change as you suggest.
|
Closing this PR as #535 fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #511 reflects the reason for daily generation of docker images due to tag concatenation issue, Addressing the review comments I have created this PR considering there will be only one tag passed to
build_imagefunction.I would like to get reviews on this PR if its fine to consider that there will be only one tag getting passed to
build_imageThis part of script passes only one tag
Signed-off-by: bharathappali [email protected]