-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag concatenating issue #512
Conversation
@bharathappali As mentioned, can you please add |
@dinogun I have given try in making functions use local vars but as its at multiple place I'm getting it messed up with my changes locally. As it is taking me a bit of time, the current fix solves the problem for stopping the docker images getting images updated daily. I would like to suggest a review of this PR and when its merged to look at the build jobs log to figure out at which point multiple tags are getting passed to Will be raising a new PR for the correction of local and global vars. NOTE: Having a personal build feature at https://ci.adoptopenjdk.net/ for the changes to personal forks of Please correct me if I'm wrong. |
@bharathappali - Can you rebase this and we'll take another look. |
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
1470a5a
to
232b9d8
Compare
@karianna I have made changes to remove the loop as the loop iterating the tags is not required (multiple tags are not been passed - https://ci.adoptopenjdk.net/view/Docker%20Images/job/openjdk_build_docker_multiarch/266/consoleText all the entries are having only Rebased to the current level. It's ready for review. |
This PR is not needed anymore as the changes in the Alpine PR make it redundant. |
@dinogun can I please have a pointer to the Alpine PR ? |
Closing this as #535 fixes it |
The adopt image tag is been extracted here which expects only one tag in the format
-t repo:tag
but the sequence of tags are passed earlier so its resulting in a big concatenated string where-t
are removed. So removing the loop as only one tag is getting passed tobuild_image
hereFixes #511
@dinogun @karianna Can i please have your views on this ?