Check if maxage header value is valid before setting it #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Feb 1, 2024
.../java/com/adobe/acs/commons/http/headers/impl/PropertyBasedDispatcherMaxAgeHeaderFilter.java
Show resolved
Hide resolved
senn
force-pushed
the
improvement/check-valid-maxage-value
branch
from
9cb2de8 to
8a056c0
Compare
senn
force-pushed
the
improvement/check-valid-maxage-value
branch
from
8a056c0 to
34e53ce
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3252 +/- ##
===========================================
- Coverage 1.34% 1.34% -0.01%
Complexity 44 44
===========================================
Files 721 721
Lines 29515 29522 +7
Branches 3837 3838 +1
===========================================
Hits 397 397
- Misses 29102 29109 +7
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
Indeed, looks very good! Can this be merged quickly, would be nice to have it in the next release @kwin @davidjgonzalez |
|
@senn can you add a Changelog entry? |
davidjgonzalez
merged commit f53e9ad
into
Adobe-Consulting-Services:master
19 of 21 checks passed
|
Thx for the fast actions, everybody! @davidjgonzalez I see you have already added the changelog yourself. ✅ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but useful fix for issue #3251
I'm hoping this could get some fast reviews and approvals, and even a fast release. We could use this fix asap.