issue #2960 shared-component-properties add support for lazy bindings, require AEM 6.5.7+ #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcin
changed the title
adamcin
force-pushed
the
feature/issue-2960-scpbvp-support-lazy-bindings-version-600
branch
3 times, most recently
from
3937876 to
8833320
Compare
Codecov Report
@@ Coverage Diff @@
## acs-aem-commons-6.0.0 #2964 +/- ##
===========================================================
+ Coverage 54.60% 54.64% +0.04%
- Complexity 5256 5274 +18
===========================================================
Files 697 697
Lines 28395 28418 +23
Branches 3658 3654 -4
===========================================================
+ Hits 15506 15530 +24
- Misses 11436 11438 +2
+ Partials 1453 1450 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adamcin
force-pushed
the
feature/issue-2960-scpbvp-support-lazy-bindings-version-600
branch
from
8833320 to
027f47f
Compare
|
So... I think something related to these two links is causing some unit tests to break in java17 that pass in java11, AFTER upgrading to SLING-8116 ValueMap - implement default methods using OSGI Converter https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html |
…per LazyBindings types
adamcin
force-pushed
the
feature/issue-2960-scpbvp-support-lazy-bindings-version-600
branch
from
027f47f to
2641f56
Compare
…upport-lazy-bindings-version-600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proper approach to resolving #2960 in a way that requires an increase in the minimum supported AEM version to 6.5 SP7.
I rebased the master PR branch for pre-6.5.7 support and then added a commit to upgrade the platform dependencies to 6.5.7 and replace the use of reflection with proper LazyBinding types.
@joerghoh @kwin @HitmanInWis @davidjgonzalez