removing workaround for 5.6.1 bug. fixes #530.

Adobe-Consulting-Services · Sep 11, 2015 · c93c6c3 · c93c6c3
1 parent 0e271b6
commit c93c6c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 39 deletions.
diff --git a/bundle/src/main/java/com/adobe/acs/commons/xss/XSSFunctions.java b/bundle/src/main/java/com/adobe/acs/commons/xss/XSSFunctions.java
@@ -104,32 +104,7 @@ public static CharSequence filterHTML(XSSAPI xssAPI, String source) {
      */
     @Function
     public static CharSequence getValidHref(XSSAPI xssAPI, String source) {
-        try {
-            final String testHtml = LINK_PREFIX + mangleNamespaces(source) + LINK_SUFFIX;
-
-            final String safeHtml = xssAPI.filterHTML(testHtml);
-            return safeHtml.substring(LINK_PREFIX.length(), safeHtml.length() - LINK_SUFFIX.length());
-        } catch (final Exception e) {
-            return "";
-        }
-    }
-
-    private static String mangleNamespaces(String absPath) {
-        if (absPath != null && absPath.contains(MANGLE_NAMESPACE_OUT_SUFFIX)) {
-            final Matcher m = MANGLE_NAMESPACE_PATTERN.matcher(absPath);
-
-            final StringBuffer buf = new StringBuffer();
-            while (m.find()) {
-                final String replacement = MANGLE_NAMESPACE_IN_PREFIX + m.group(1) + MANGLE_NAMESPACE_IN_SUFFIX;
-                m.appendReplacement(buf, replacement);
-            }
-
-            m.appendTail(buf);
-
-            absPath = buf.toString();
-        }
-
-        return absPath;
+        return xssAPI.getValidHref(source);
     }
 
     private XSSFunctions() {

diff --git a/bundle/src/test/java/com/adobe/acs/commons/xss/XSSFunctionsTest.java b/bundle/src/test/java/com/adobe/acs/commons/xss/XSSFunctionsTest.java
@@ -71,21 +71,11 @@ public void testFilterHTML() {
     }
 
     @Test
-    public void testGetValidHrefUnMangled() {
+    public void testGetValidHref() {
         final String test = "/content/foo.html";
-        final String expectedHtml = "<a href='/content/foo.html'></a>";
-        when(xssAPI.filterHTML(expectedHtml)).thenReturn(expectedHtml);
+        when(xssAPI.getValidHref(test)).thenReturn(test);
         XSSFunctions.getValidHref(xssAPI, test);
-        verify(xssAPI, only()).filterHTML(expectedHtml);
-    }
-
-    @Test
-    public void testGetValidHrefMangled() {
-        final String test = "/content/foo/jcr:content/bar.html";
-        final String expectedHtml = "<a href='/content/foo/_jcr_content/bar.html'></a>";
-        when(xssAPI.filterHTML(expectedHtml)).thenReturn(expectedHtml);
-        XSSFunctions.getValidHref(xssAPI, test);
-        verify(xssAPI, only()).filterHTML(expectedHtml);
+        verify(xssAPI, only()).getValidHref(test);
     }
 
     @Test