Improve systemd service management #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! LGTM & thank you for your contribution, you will be credited for your work as part of future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd 220(released in 2015) supports the "--now" switch.
When this switch is present, the units that are enabled will also be started, and the ones disabled also stopped.
This is a good opportunity to remove some unnecessary lines of code and improve code readability.
We can start and stop services with just one single command:
Also, systemctl daemon-reload is not really necessary when disabling/enabling a service.
Let me know if you notice any unintended side effects or if you have any feedback in general!