fix ValueError: invalid mode: 'rU' with python3.11 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python3, the universal newline mode 'U' has no effects. Since python3.11, that mode is obsolete and its use raises: Command: scoary.py -g scoary/exampledata/Gene_presence_absence.csv -t scoary/exa mpledata/Tetracycline_resistance.csv -o Test1 --no-time Traceback (most recent call last): File "/<<PKGBUILDDIR>>/scoary.py", line 25, in <module> methods.main() File "/<<PKGBUILDDIR>>/scoary/methods.py", line 184, in main with open(args.genes, "rU") as genes, \ ^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid mode: 'rU' Note this patch suppresses various references to the 'U' mode in calls to the "open" function, which most likely breaks compatibility of Scoary with python2. Given that this interpreter version is out of maintenance since 2020, it should not be too problematic.
|
Thanks for this. Hopefully this will be merged in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python3, the universal newline mode 'U' has no effects. Since python3.11, that mode is obsolete and its use raises:
Note this patch suppresses various references to the 'U' mode in calls to the "open" function, which most likely breaks compatibility of Scoary with python2. Given that this interpreter version is out of maintenance since 2020, it should not be too problematic.