[AG-38479] Updated userscript development section in extensions article #632
+176
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurrx
requested review from
sfionov,
ameshkov,
maximtop,
slavaleleka and
el-termikael
|
Preview was deployed to: https://pull-request-632.kb-adg.pages.dev/ |
el-termikael
requested changes
Dec 23, 2024
|
Preview was deployed to: https://pull-request-632.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-632.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-632.kb-adg.pages.dev/ |
ameshkov
approved these changes
Dec 24, 2024
el-termikael
requested changes
Dec 24, 2024
docs/general/extensions.md
Outdated
| * @param value Value of attribute that needs to be converted. | ||
| * @param elementNS Element namespace, if empty defaults to the HTML namespace. | ||
| * @param attrNS Attribute namespace, if empty defaults to null. | ||
| * @param value Value of an attribute to be converted. |
There was a problem hiding this comment.
Suggested change
| * @param value Value of an attribute to be converted. | |
| * @param value — a value of an attribute to be converted. |
There was a problem hiding this comment.
Это документация внутри кода, тут думаю "-" и артикли не нужны.
Все таски ниже резолвлю тоже
maximtop
approved these changes
Dec 24, 2024
|
Preview was deployed to: https://pull-request-632.kb-adg.pages.dev/ |
el-termikael
approved these changes
Dec 24, 2024
ameshkov
approved these changes
Dec 25, 2024
slavaleleka
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.