Merge branch 'close_file_on_error' into 'master'

Fix cascade IO crashes after unexpected error

Closes #148

See merge request eng/ide/libadalang-tools!191

src/test-common.adb

@@ -861,7 +861,9 @@ package body Test.Common is
 
    procedure Close_File is
    begin
-      Char_Sequential_IO.Close (Output_File);
+      if Char_Sequential_IO.Is_Open (Output_File) then
+         Char_Sequential_IO.Close (Output_File);
+      end if;
    end Close_File;
 
    ------------------

src/test-skeleton.adb

@@ -578,6 +578,8 @@ package body Test.Skeleton is
          Suite_Data.TR_List.Clear;
          Suite_Data.ITR_List.Clear;
          Suite_Data.LTR_List.Clear;
+
+         Close_File;
       end Cleanup;
 
       ----------------------------

src/test-stub.adb

@@ -369,6 +369,8 @@ package body Test.Stub is
          Data.Elem_Tree.Clear;
          Data.Flat_List.Clear;
          Data.Limited_Withed_Units.Clear;
+
+         Close_File;
       end Cleanup;
 
       ------------------------

testsuite/tests/test/error_recovery/importing.ads

@@ -0,0 +1,6 @@
+with Wrong_1;
+with Wrong_2;
+with Right;
+package Importing is
+   function F return Integer is (1);
+end importing;

testsuite/tests/test/error_recovery/p.gpr

@@ -0,0 +1,2 @@
+project p is
+end p;

testsuite/tests/test/error_recovery/right.adb

@@ -0,0 +1,6 @@
+package body Right is
+   function F return String is
+   begin
+      return "foo";
+   end F;
+end Right;

testsuite/tests/test/error_recovery/right.ads

@@ -0,0 +1,3 @@
+package Right is
+   function F return String;
+end Right;

testsuite/tests/test/error_recovery/test.out

@@ -0,0 +1,4 @@
+gnattest: name resolution error for <Id "Some_Type" wrong_1.ads:3:56-3:65>
+gnattest: unexpected error while creating stub for wrong_1.ads
+gnattest: name resolution error for <Id "Some_Type" wrong_2.ads:3:46-3:55>
+gnattest: unexpected error while creating stub for wrong_2.ads

testsuite/tests/test/error_recovery/test.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+GNATTEST_STRICT=False gnattest -P p --stub importing.ads -q

testsuite/tests/test/error_recovery/test.yaml

@@ -0,0 +1,5 @@
+description:
+    Test error recovery
+
+driver: shell_script
+

testsuite/tests/test/error_recovery/wrong_1.adb

@@ -0,0 +1,6 @@
+package body Wrong_1 is
+   procedure Cannot_Stub (X : in out Missing.Something.Some_Type) is
+   begin
+      null;
+   end Cannot_Stub;
+end Wrong_1;

testsuite/tests/test/error_recovery/wrong_1.ads

@@ -0,0 +1,4 @@
+with Missing.Something;
+package Wrong_1 is
+   procedure Cannot_Stub (X : in out Missing.Something.Some_Type);
+end Wrong_1;

testsuite/tests/test/error_recovery/wrong_2.adb

@@ -0,0 +1,6 @@
+package body Wrong_2 is
+   procedure Cannot_Stub (X : in out Missing.Some_Type) is
+   begin
+      null;
+   end Cannot_Stub;
+end Wrong_2;

testsuite/tests/test/error_recovery/wrong_2.ads

@@ -0,0 +1,4 @@
+with Missing;
+package Wrong_2 is
+   procedure Cannot_Stub (X : in out Missing.Some_Type);
+end Wrong_2;